Closed Bug 1205578 Opened 10 years ago Closed 10 years ago

[lockscreen] lockscreen still milky colored even if all notifications are cleared

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-master verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-master --- verified

People

(Reporter: mozilla, Assigned: prateekjadhwani, Mentored)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

[gaia] prateekjadhwani:1205578 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review
verified_Aires_v2.6.3gp
2.51 MB, video/3gpp
Details
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150826185918 Steps to reproduce: 1. getting a notification on lockscreen 2. open lockscreen 3. all notifications are cleared 4. press powerbutton so screen is off 5. wake up again to go into lockscreen Actual results: the lockscreen with all former cleared notifications is still "milky" colored, even there is no notification to show. Expected results: lockscreen should be show the background picture clear and not in that milky state.
Component: General → Gaia::System::Lockscreen
Status: UNCONFIRMED → NEW
Ever confirmed: true
[Blocking Requested - why for this release]: Visual regression that can be seen by nearly every user. I experienced it in the latest dogfood update[1] [1] Build ID 20151002110438 Gaia Revision 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b Gaia Date 2015-10-02 03:13:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/5f16c6c2b969f70e8da10ee34853246d593af412 Gecko Version 44.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150619.224059 Firmware Date Fri Jun 19 22:41:08 UTC 2015 Bootloader s1
blocking-b2g: --- → 2.5?
status-b2g-master: --- → affected
Keywords: regression
Regression. Needs a fix. P2 priority, blocks 2.5
blocking-b2g: 2.5? → 2.5+
Priority: -- → P2
Can someone please assign this bug to me. I am starting to debug it. - Thanks
Flags: needinfo?(jlorenzo)
Flags: needinfo?(jlorenzo) → needinfo?(administration)
You don't really need to wait for be the assignee before start the investigation :) Not sure if you need mentor or not but I am just going to assign one so we don't lost track of it. Also this is a release blocker which means it must be fixed within this one or two weeks.
Assignee: nobody → prateekjadhwani
Mentor: gweng, timdream
Status: NEW → ASSIGNED
Flags: needinfo?(administration)
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #4) > You don't really need to wait for be the assignee before start the > investigation :) > > Not sure if you need mentor or not but I am just going to assign one so we > don't lost track of it. > > Also this is a release blocker which means it must be fixed within this one > or two weeks. I see. Thanks.
Comment on attachment 8676535 [details] [review] [gaia] prateekjadhwani:Bug-1205578 > mozilla-b2g:master Tim, I just created a PR for this. I was wondering if you could take a look at it. Thanks
Attachment #8676535 - Flags: review?(timdream)
Attachment #8676535 - Flags: review?(timdream) → review?(gweng)
Comment on attachment 8676535 [details] [review] [gaia] prateekjadhwani:Bug-1205578 > mozilla-b2g:master Thanks for patching. From the code I think it's good, except there are two issues need to be done first: 1. It's necessary to add an new unit test in |lockscreen_test.js| 2. "transparent" need to be 'transparent', since we use single quotes for strings.
Attachment #8676535 - Flags: review?(gweng)
Comment on attachment 8676535 [details] [review] [gaia] prateekjadhwani:Bug-1205578 > mozilla-b2g:master Hi Greg, I made the changes as per the comments. I was wondering if you could take a look at them again. Thanks
Attachment #8676535 - Flags: review?(gweng)
Comment on attachment 8676535 [details] [review] [gaia] prateekjadhwani:Bug-1205578 > mozilla-b2g:master It looks good to me now. Thanks.
Attachment #8676535 - Flags: review?(gweng) → review+
Greg, I dont think I have rights to add the keyword `checkin-needed` to the bug. Can this be merged? Thanks
Flags: needinfo?(gweng)
Could you please squash all the commits into one, and name them as 'Bug 1205578 - ....' first? I can't land it with these individual commits.
Flags: needinfo?(gweng)
Comment on attachment 8676535 [details] [review] [gaia] prateekjadhwani:Bug-1205578 > mozilla-b2g:master Not able to squash the merge pull requests. Will have to close this PR.
Attachment #8676535 - Attachment is obsolete: true
Comment on attachment 8679408 [details] [review] [gaia] prateekjadhwani:1205578 > mozilla-b2g:master Created a new PR with squashed commit.
Attachment #8679408 - Flags: review?(gweng)
Comment on attachment 8679408 [details] [review] [gaia] prateekjadhwani:1205578 > mozilla-b2g:master The code still looks good (and that's what reviewing for). We just need to take care if this breaks the transparent background like Bug 1198324 (Text on lock-screen is unreadable if you have a light background).
Attachment #8679408 - Flags: review?(gweng) → review+
master: https://github.com/mozilla-b2g/gaia/commit/5fa8fdd3a70f7e003d85bcc2d3c9299b047de918
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #17) > Comment on attachment 8679408 [details] [review] > [gaia] prateekjadhwani:1205578 > mozilla-b2g:master > > The code still looks good (and that's what reviewing for). We just need to > take care if this breaks the transparent background like Bug 1198324 (Text > on lock-screen is unreadable if you have a light background). Thank You for the merge. I might have a suggestion for that bug. Let me post it there.
Attached video verified_Aires_v2.6.3gp —
This bug has been verified as "pass" on the latest Aires KK 2.6 by the STR in comment 0. Actual results: Lockscreen shows the background picture clear and not in that milky state. See attachment: verified_Aries_v2.6.3gp Reproduce rate: 0/10 Device: Aries KK 2.6 (Pass) Build ID 20151103000930 Gaia Revision 7954ff0cbd794a35499a1082bed273598f82ee6f Gaia Date 2015-11-02 17:35:17 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9f69202d82752e093a653a8f15b0274e347db33a Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151102.233051 Firmware Date Mon Nov 2 23:30:58 UTC 2015 Bootloader s1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: