1205823 - Unsign multi-package XPIs that were signed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

In bug 1172696 we reverted the signing of the multi-package XPIs. We however didn't unsign the ones that were already signed.

I think it's a matter of restoring the backups that are created when a file is signed.

Comment 1

[Mathieu Agopian [:magopian]]

To get the list of addon IDs which are signed multi-packages, to unsign:

select distinct(addons.id) from files, versions, addons where files.version_id = versions.id and versions.addon_id = addons.id and files.is_multi_package = 1 and files.is_signed=1;

Then feed that to the "manage.py unsign_addons" script.

If there are any logs saying "Backup <file path> does not exist, skip", then we'll need to deal with those manually (that means they weren't signed automatically, with a backup created on disk, but where submitted in the short timeframe where we would sign multi-package XPIs when they were submitted and approved).

This needs the following PR: https://github.com/mozilla/olympia/pull/760

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/eceb57d4db4a397bca7f1b5efd76720bcf90df41
Unsign the multi-package XPIs that we had signed (bug 1205823)

https://github.com/mozilla/olympia/commit/55502e44f245e93ba78ded922e09c62f167fc5d6
Merge pull request #760 from magopian/1205823-unsign-multi-package-xpi

Unsign the multi-package XPIs that we had signed (bug 1205823)

Comment 3

[Mathieu Agopian [:magopian]]

Assigning to :krupa to see when we can test that on -dev/stage

Comment 4

[Andy McKay]

Marking reso fixed so qa can test.