Closed Bug 1205946 Opened 11 years ago Closed 6 years ago

assert that gfxFontPrefLangList.h entries match prefs

Categories

(Core :: Graphics: Text, defect, P3)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: heycam, Assigned: heycam)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Attached patch patch — — Splinter Review
This wouldn't have caught bug 1205570, although we could extend it to look additionally for prefs like font.name.serif.LANG and check that there is a font.default.LANG too.
Attachment #8662760 - Flags: review?(jdaggett)
Looks good but I'd like to hold off on this. I'm moving pref font related code into gfxPlatformFontList as part of bug 1182361, so it would be easier to rework this patch a tad after those patches are landed.
Assignee: nobody → cam
Depends on: 1182361
Comment on attachment 8662760 [details] [diff] [review] patch Clearing the review for this, as the patch needs to be tweaked based on recent changes.
Attachment #8662760 - Flags: review?(jdaggett)
Cam, have you made any progress on this?
Flags: needinfo?(cam)
Whiteboard: [gfx-noted]
No, this is not high enough up my priority list to get to any time soon.
Flags: needinfo?(cam)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: