120621 - Print and Print preview ignore the margin setting

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Jean-Marc Desperrier]

Tested on 2002011703

Steps : 
- change the values for margin in the Page Setup Dialog
- print the page or do a Print Preview
- whatever value you set in the margin option, you get exactly the same result

I had the same behaviour with print preview under Linux with 2002010308.

Comment 1

[rods (gone)]

Attachment: patch

I really can't explain where and how this got broken. Because I know I tested
this. Oh, well. The key here is you HAVE to be able to get the margins out of
the PrintSettings before you do the reflow.

Comment 2

[dcone (gone)]

Comment on attachment 65480 [details] [diff] [review]
patch

r=dcone

Comment 3

[Marc Attinasi]

Comment on attachment 65480 [details] [diff] [review]
patch

sr=attinasi

Comment 4

[David Hyatt]

sr=hyatt

Comment 5

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.8

Comment 6

[rods (gone)]

fixed

Comment 7

[sujay]

Jean-Marc, please verify....and mark verified-fixed...thanks.

Comment 8

[Jean-Marc Desperrier]

verified-fixed with 2002020103.

They are other problems :
- "Page Scaling" does not seem to be saved. 
I see the same problem as there was with margins.
Modify the value, click OK, reopen the dialog, the value is back to 100.

- Print preview problem with headers display. 
When using small marging, the display is quite wrong, especially the headers do
not quite appear the way they will in print.
I will open a bug for that, but it does not seem very severe.

Comment 9

[sujay]

please file nbew bugs for those other problems.

Comment 10

[sujay]

so if a new bug is gonna be filed, can we close out this one and mark it
VERIFIED-FIXED ?

Comment 11

[Jean-Marc Desperrier]

I filed two other bugs :
- bug 123342 : changes to "Page Scaling" value in page setup dialog ignored 
- bug 123345 : changes to "Header" values in page setup dialog impossible

About the display of header with small margin, I will fill a bug when I have 
time for a complete description, and it's not so important, the printing itself 
is right.
Can be closed

Comment 12

[sujay]

Jean-Marc, so this bug can be closed...Please mark it verified-fixed..thanks!

Comment 13

[Jean-Marc Desperrier]

Verified.

Sorry "http://www.mozilla.org/bugs/" says it's QA that marks bugs as Verified , 
and also I wasn't sure there was really a difference between RESOLVED-FIXED, and 
VERIFIED-FIXED.