1206222 - puppet error when bringing up a new buildbot master

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]: message repeated 2 times: [ (Scope(Buildmaster::Buildbot_master::Mozilla[bm07-tests1-linux32])) Could not look up qualified variable 'buildmaster::settings::lock_dir'; class buildmaster::settings has not been evaluated]
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]: (Scope(Buildmaster::Buildbot_master::Mozilla[bm07-tests1-linux32])) Could not look up qualified variable 'buildmaster::settings::postrun_template'; class buildmaster::settings has not been evaluated
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]: Failed to parse template buildmaster/:
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/parser/templatewrapper.rb
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Line: 100
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Detail: Is a directory - /etc/puppet/production/modules/buildmaster/templates/
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:  at /etc/puppet/production/modules/buildmaster/manifests/buildbot_master/mozilla.pp:77 on node buildbot-master07.bb.releng.usw2.mozilla.com
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]: Failed to parse template buildmaster/:
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/parser/templatewrapper.rb
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Line: 100
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Detail: Is a directory - /etc/puppet/production/modules/buildmaster/templates/
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:  at /etc/puppet/production/modules/buildmaster/manifests/buildbot_master/mozilla.pp:77 on node buildbot-master07.bb.releng.usw2.mozilla.com
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]: Failed to parse template buildmaster/:
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/parser/templatewrapper.rb
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Line: 100
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:   Detail: Is a directory - /etc/puppet/production/modules/buildmaster/templates/
Sep 18 13:22:02 releng-puppet1.srv.releng.use1.mozilla.com puppet-master[30696]:  at /etc/puppet/production/modules/buildmaster/manifests/buildbot_master/mozilla.pp:77 on node buildbot-master07.bb.releng.usw2.mozilla.com

seems like an ordering issue

Comment 1

[Kim Moir [:kmoir] ET]

brought done (hung in puppet process) buildbot-master07 until I can implement a patch

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1206222.patch

I tested this in staging and the buildbot-master07 fully puppetized.  I missed the $node_security_level = 'high' earlier because the script mentioned in the wiki generate the puppet bits for new masters is missing this, I'll fix this.  I think the buildmaster::base bits were removed in an earlier refactoring, perhaps bug 971775?

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8664331 [details] [diff] [review]
bug1206222.patch

Ooops. Sorry, I missed this in the initial review.