1206251 - Refresh the identity block when permissions change

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Comment 1

[:Paolo Amadini]

Since we have an observer notification for permissions. and permissions change rarely, we can simply listen for any changes in the front-end and refresh the identity block when that happens.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: New control center behavior

Ash, here's something you might want to be aware of with this patch applied.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Old behavior

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8760590 [details]
Old behavior

Because I'm not sure the intention of the original GIF was clear, here's the interaction on stable. Note how at the end I select "Always Ask" and the select box and "Receive Notifications" text doesn't go away.

Comment 5

[Johann Hofmann [:johannh]]

Matt pointed out on IRC that the select box is going to be replaced with an [x] button in Bug 1203292. We'll have to see how that mixes with this bug.

Comment 6

[Johann Hofmann [:johannh]]

Attachment: 1206251 - Add a permission change observer to refresh the identity block.

Review commit: https://reviewboard.mozilla.org/r/58196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58196/

Comment 7

[Johann Hofmann [:johannh]]

I realize I'm mistaking identity block for identity popup here. The identity popup should probably not be automatically updated. I'll upload another patch as soon as Bug 1206246 is resolved

Comment 8

[:Paolo Amadini]

Ah, yes, this bug is about catching permission changes during browser usage. It will probably not even result in any visible user interface change until we have implemented the blocked permissions, because blocked permissions are not shown in the identity block yet. Note that notification anchors are technically not a part of the identity block.

Unless there are other reasons to do so, we can just refresh everything including the panel contents, and performance shouldn't be a concern. Permission changes should be rare as they only happen on explicit user action, and even if theoretically an add-on could make several calls to the permissions API in sequence, we shouldn't tune our code to hypothetical use cases.

Comment 9

[:Paolo Amadini]

And yeah, bug 1206246 is a good way to make this bug actually do something visible.

Comment 10

[Johann Hofmann [:johannh]]

Comment on attachment 8760688 [details]
1206251 - Add a permission change observer to refresh the identity block.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58196/diff/1-2/

Comment 11

[Johann Hofmann [:johannh]]

After a chat with MattN I decided to not reload the identity popup (only the identity block) until we see how that interoperates with the changes in Bug 1203292. Reloading the popup would be easy to add. r? :)

Comment 12

[:Paolo Amadini]

Comment on attachment 8760688 [details]
1206251 - Add a permission change observer to refresh the identity block.

https://reviewboard.mozilla.org/r/58196/#review56722

Sorry for the delay!

Comment 13

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e709187cf696

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/1176a934e5ba
Add a permission change observer to refresh the identity block. r=paolo

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1176a934e5ba

Comment 16

[Saheda Reza [:Antora]]

I have successfully reproduced this issue on Nightly according to(2015-09-18)

Fixing bug is verified on Latest Developer Edition--  Build ID:( 20160826004001 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0

Tested OS -- Windows10 32bit

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

Thanks!