Closed Bug 1282223 Opened 6 years ago Closed 6 years ago

Remove gPermissionObserver

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 1206251 added a gPermissionObserver object to the global browser.xul scope, but it should have just extended the gPermissionObserver object where all the related code is encapsulated.
Attachment #8765172 - Flags: review?(paolo.mozmail)
Attachment #8765172 - Flags: review?(paolo.mozmail) → review?(gijskruitbosch+bugs)
Comment on attachment 8765172 [details] [diff] [review]
patch

Review of attachment 8765172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/base/content/browser.js
@@ +7247,5 @@
>  
>      return container;
> +  },
> +
> +  observe: function (subject, topic, data) {

Nit: please use the shorthand observe(subject, topic, data) { instead, and personally I would prefer adding this directly after the handleEvent() implementation. Up to you.

I would also prefer to split this whole thing off to its own file, because browser.js is too much of a dumping ground and this object takes up about 10% (!) of it, but that can be its own bug, if you agree that makes sense? :-)
Attachment #8765172 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5d888fb5d239
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.