1282223 - Remove gPermissionObserver

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Bug 1206251 added a gPermissionObserver object to the global browser.xul scope, but it should have just extended the gPermissionObserver object where all the related code is encapsulated.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8765172 [details] [diff] [review]
patch

Review of attachment 8765172 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/base/content/browser.js
@@ +7247,5 @@
>  
>      return container;
> +  },
> +
> +  observe: function (subject, topic, data) {

Nit: please use the shorthand observe(subject, topic, data) { instead, and personally I would prefer adding this directly after the handleEvent() implementation. Up to you.

I would also prefer to split this whole thing off to its own file, because browser.js is too much of a dumping ground and this object takes up about 10% (!) of it, but that can be its own bug, if you agree that makes sense? :-)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/5d888fb5d239
Remove gPermissionObserver. r=gijs

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d888fb5d239