1206272 - can not go into settings -> home screens because panels/homescreens/wallpaper isn't loaded

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[ralf tauscher]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826185640

Steps to reproduce:

1. open settings
2. select home screens


Actual results:

home screens is getting blue, but it will not switch into it


Expected results:

Home screens settings should open

Comment 1

[ralf tauscher]

logcat gives me this:

E/Settings(18282): [JavaScript Error: "Error: Not loaded: panels/homescreens/wallpaper" {file: "app://settings.gaiamobile.org/js/vendor/alameda.js" line: 41}]

Comment 2

[ralf tauscher]

settings -> display can be opened, but the wallpaper section is missing

Comment 3

[ralf tauscher]

I am on
commit 27a86ef0e13fa7d02417a5094bb2712a67a623ab

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Once tapped on "Home Screens", the Settings app is broken and has to be terminated in the task switcher and relaunched to access the other panels.

Comment 5

[helen（leave from Mozilla）]

Attachment: Aries KK v2.5.3gp

This bug can be repro on latest build of Aries KK v2.5 and Flame KK v2.5 but cannot be repro on latest Flame KK v2.2. 

Actual Result:
1.The Home Screens potion in Settings will getting blue when tapping on it, but it will not switch into it. 

2.And long tap home page and launch Homesscreen Settings will also appears a blank page.

3.Display can be opened, but the wallpaper section is missing.

See attachment: Aries KK v2.5.3gp & logcat0317.txt

Reproduce rate: 5/5

Device: Aries KK v2.5 (Affected) 
Build ID               20150920050928
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150920.042926
Firmware Date          Sun Sep 20 04:29:33 UTC 2015
Bootloader             s1

Device: Flame KK 2.5 (Affected)
Build ID               20150920150205
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150920.182952
Firmware Date          Sun Sep 20 18:30:04 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.2 (Unaffected)
Build ID               20150920032503
Gaia Revision          95950c9d48ad2fc2da7686c2b133b750a99cd3da
Gaia Date              2015-09-18 09:55:13
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/38d6133e2416
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150920.065310
Firmware Date          Sun Sep 20 06:53:21 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 6

[helen（leave from Mozilla）]

Attachment: logcat0317.txt

Comment 7

[helen（leave from Mozilla）]

B2G-inbound Regression Window:

Last Working Environmental Variables:
Build ID               20150918024053
Gaia Revision          4f22dfecdc046fe5223ee858dd06c11b75884740
Gaia Date              2015-09-18 05:36:26
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/15859b18d22eb42fa922ce6ecb2ea177fe227dc5
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150918.183034
Firmware Date          Fri Sep 18 18:30:44 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Build ID               20150918025354
Gaia Revision          c4ae7873e0db54e3998cd7b5fa7de05caaebb27b
Gaia Date              2015-09-18 09:31:11
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/ceff400b7ee3aec3b01017b0c724229aec7a295a
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150915.182947
Firmware Date          Tue Sep 15 18:29:57 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia-Rev        c4ae7873e0db54e3998cd7b5fa7de05caaebb27b
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/15859b18d22eb42fa922ce6ecb2ea177fe227dc5

First Broken Gecko & Last Working Gaia – issue DOES NOT repro
Gaia-Rev        4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/ceff400b7ee3aec3b01017b0c724229aec7a295a

Gecko pushlog:
https://github.com/mozilla-b2g/gaia/compare/4f22dfecdc046fe5223ee858dd06c11b75884740...c4ae7873e0db54e3998cd7b5fa7de05caaebb27b

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Guillaume, this seems to be a regression from bug 1180666, can you investigate, please?

Comment 9

[Norry.L.F(Leave from Mozilla)]

[Blocking Requested - why for this release]:
Nominate. Regression bug, and Settings page will be blank, and wallpaper disappears.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1206272-Can-not-go-into-settings-home-screens > mozilla-b2g:master

Comment 11

[Guillaume Marty [:gmarty]]

Comment on attachment 8663714 [details] [review]
[gaia] gmarty:Bug-1206272-Can-not-go-into-settings-home-screens > mozilla-b2g:master

It seems that the build system doesn't like arrow functions.
Fred, can you take a look at the patch?

Comment 12

[Hema Koka [:hema]]

gasolin, 

please help with the review here -- we need to close on this dogfood blocker asap to move ahead with the dogfood build.  

also adding kevin to see if he can help in anyway during US day time. 

thanks much!

hema

Comment 13

[Hema Koka [:hema]]

gmarty - assigning to you since you have patch up for review :)

Comment 14

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted to test around the patch before it lands.

Comment 15

[[e-mail]]

Comment on attachment 8663714 [details] [review]
[gaia] gmarty:Bug-1206272-Can-not-go-into-settings-home-screens > mozilla-b2g:master

Thanks for finding it out. 

To prevent alike issues I'll add some notice about the require.config in settings readme.

Comment 16

[Hema Koka [:hema]]

(In reply to Fred Lin [:gasolin] from comment #15)
> Comment on attachment 8663714 [details] [review]
> [gaia] gmarty:Bug-1206272-Can-not-go-into-settings-home-screens >
> mozilla-b2g:master
> 
> Thanks for finding it out. 
> 
> To prevent alike issues I'll add some notice about the require.config in
> settings readme.

Thanks Fred! Appreciate your help on this one!

Comment 17

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I checked the patch after applying it to the latest Flame and Aries builds.  I was able to access the Home Screens setting and all other settings through the settings app. 

However the Homescreen Settings accessed by bringing up the context menu on the Homescreen leads to a blank page.  This is being investigated separately as it occurs without the patch as well.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150922115027
Gaia: e74a67cf5c1284442430e710ecb7455805d32205
Gecko: a1ccea59e254a88f7bb44b0ad8a58b77b7eca339
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20150922030227
Gaia: e74a67cf5c1284442430e710ecb7455805d32205
Gecko: 2235e56c94cf61614902fd3a4ac7b837f7154b97
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hey Mr. Marty!  Could you look at the comment in regards to the patch please?  The issue I don't think is a blocker, having said that it would be good to get a fix in.

Comment 19

[[e-mail]]

merged in f480bac.

Sorry I did this on aries and only nightly version allow me to copy paste text from sms :p

Comment 20

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Jayme, can you file a bug in regards to the issue you found?  I'll produce a FOTA build since it's already been pushed according to Fred.

Comment 21

[[e-mail]]

Naoki I think what you mentioned is filed in bug 1207308, and is fixed as well (though might need UX confirm later)

Comment 22

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fred is correct, bug 1207308 was the bug I mentioned.

Comment 23

[Martin Shuman [:Marty]]

This issue is verified fixed on the latest Aries and Flame 2.5 master builds.
The Home Screens menu opens properly, and does not interfere with the functionality of the rest of the Settings app.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150924111215
Gaia: 4bb17b24620818cbda0ba0c0d69e0ce3f914e1b7
Gecko: 001942e4617b2324bfa6cdfb1155581cbc3f0cc4
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20150924030228
Gaia: 4bb17b24620818cbda0ba0c0d69e0ce3f914e1b7
Gecko: bf2bc1aa78c0b72d9b6b13f7a8c6ae61c60a51dc
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 24

[Guillaume Marty [:gmarty]]

Hey Naoki-san, what bug are you referring to in Comment 18.

Comment 25

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

based on comment 17, https://bugzilla.mozilla.org/show_bug.cgi?id=1207308.  No need to worry about it since it's resolved.  :) Thanks!