1207308 - Long pressing on the homescreen to display Homescreen Settings will show a blank settings window with only a 'Settings' header and 'Done' button.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-homescreen-settings.txt

Description:
If the user attempts to change homescreen settings by long-pressing empty space on the homescreen, they will be presented with a blank screen with only a header and a 'Done' button


Repro Steps:
1) Update a Aries to 20150922115027
2) Long press on an empty part of the homescreen
3) At the context window, select 'Homescreen Settings'

Actual:
The user is taken to a blank Settings window.

Expected:
The user is properly taken to a functioning Homescreen Settings window.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150922115027
Gaia: 68361828ae88dffd04b250121b5f2472a63f4bf0
Gecko: a1ccea59e254a88f7bb44b0ad8a58b77b7eca339
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 8/8
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
The user is taken to a blank Settings window.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150922030227
Gaia: 29991414eb94b6baa1ec2e63fdb4f6dfae05fb01
Gecko: 2235e56c94cf61614902fd3a4ac7b837f7154b97
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0


This issue does NOT occur on the latest Flame 2.2 build.
The user is properly taken to a functioning Homescreen Settings window.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150922032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fa496da3e47f
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[[e-mail]]

Hmm the config panel for default homescreen is changed to #homescreen_detail, not sure if it's possible to be trigger directly.

Comment 3

[[e-mail]]

With the context (Long press on Homescreen and select the 'Homescreen Settings' option will navigate to ...), I suppose the possible settings panel is the `homescreens list` page, which list all available homescreens and user could choose one of them or config the detail. 

Jacqueline how do you think?

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1207308 > mozilla-b2g:master

Comment 5

[[e-mail]]

Comment on attachment 8664603 [details] [review]
[gaia] gasolin:issue-1207308 > mozilla-b2g:master

one line fix since settings' manage homescreen panel is refactored and now the correspondent panel id might be `homescreen_list` if UX agree with that. (If not, just deprecate this patch)

Comment 6

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/9539d6040f797bba8f7fe8dfd91d569e7b5ba821

We should probably add marionette tests for this in the near future to make sure this doesn't regress (which is unlikely, but still).

Comment 7

[Jacqueline Savory [:jsavory] UX]

Yup, I agree the 'Homescreen Settings" option should go to Settings > Home Screen so the user can directly make any changes they want to.

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Long pressing on the homescreen and tapping "Homescreen Settings", the Homescreen Settings page displays normally.
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150924150202
Gaia Revision          4bb17b24620818cbda0ba0c0d69e0ce3f914e1b7
Gaia Date              2015-09-23 16:06:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/001942e4617b2324bfa6cdfb1155581cbc3f0cc4
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150924.183612
Firmware Date          Thu Sep 24 18:36:29 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150925003138
Gaia Revision          4bb17b24620818cbda0ba0c0d69e0ce3f914e1b7
Gaia Date              2015-09-23 16:06:39
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/eee4266046984718e4daa99d94ce820f3fd86d32
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150925.001452
Firmware Date          Fri Sep 25 00:15:01 UTC 2015
Bootloader             s1

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp

Comment 10

[Guillaume Marty [:gmarty]]

Clearing the ni.