1206291 - Audit Themed*

Status: RESOLVED DUPLICATE of bug 1105081

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Chenxia pointed out some potentially issues in bug 1201346 comment 7:

(In reply to Chenxia Liu [:liuche] from comment #7)
> Comment on attachment 8660110 [details]
> MozReview Request: Bug 1201346 - Make menu button have LWT on phones.
> r=liuche
> 
> https://reviewboard.mozilla.org/r/19077/#review17637
> 
> Looks good, this matches the ShapedButton implementation pretty well, but
> there seems to be some cargo-culting throughout all of these ThemedViews. Do
> you think we should file a bug to audit this code? Some of it just doesn't
> make sense, but I guess it works well enough right now?
> 
> ::: mobile/android/base/toolbar/ShapedButtonFrameLayout.java:25
> (Diff revision 1)
> > +    public void onLightweightThemeChanged() {
> 
> Digging through this code, we never ever call setTheme or resetTheme, which
> is weird because it's implemented in the super.
> 
> ::: mobile/android/base/toolbar/ShapedButtonFrameLayout.java:44
> (Diff revision 1)
> > +    public void onLightweightThemeReset() {
> 
> Maybe we should call through to the super here too.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Dupe bug 1105081?