1206393 - Enabling "Clear history when Firefox closes" with large history triggers shutdownhang crash, causing dataloss

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Yorgos]

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826023504

Steps to reproduce:

Close FF but selecting (for the firsttime) Delete history on shutdown 


Actual results:

https://crash-stats.mozilla.com/report/index/fb724ef4-c3be-46e9-ad3a-7d9092150919

this crash at shutdown, that happens only if the box Delete History is checked (!), corrupted myprofile, therefore all is lost here.

Comment 1

[Loic]

Is it reproducible with a fresh profile and a small history?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 2

[Yorgos]

With SMALL history all is ok.
With a BIG history it is reproducible even with clean profile. When it happens (closing FF) I have to paste my old profile (backup), because this kind crash let the profile to get corrupt. Very bad. I am a bit worried. But if you delete History Once per week, all is ok.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Almost sure it's a duplicate of bug 1215885.

Does this still reproduce?

Comment 4

[Yorgos]

It happened again.
workaround: dlear history more frequent.

not good.

Comment 5

[Yorgos]

In short:

unchecking clean history at shutdown > all is ok

checking clean history > I have to manually kill firefox.exe to get a plugincontainer.exe crash.
Always reproducible.

Comment 6

[Yorgos]

no crash report available, starting from today the profile is not destroyed, bacause I self "have to" kill firefox.exe.

Comment 7

[ovidiu boca[:Ovidiu]]

Build ID: 20151210030212
User Agent: Mozilla/5.0 (Windows NT 6.0; rv:45.0) Gecko/20100101 Firefox/45.0

I have tested this on Win Vista with FF Nightly45 and I can't reproduce this problem. I know that you have an another bug 1158482 and you have installed Nightly, can you test this problem to?

Comment 8

[Yorgos]

the history should be long, plese wait at least ome month.
with a short history even here by me all is ok ;)

Comment 9

[Yorgos]

(( OT: the biggest issue is
https://bugzilla.mozilla.org/show_bug.cgi?id=1222272
this is a blocker. all the required attachments seem unuseful, I ask to myself what could be useful, other than to ship my PC to Mozilla, par avion ;)   ))

Comment 10

[YF (Yang)]

bp-950f044a-a18f-4c6c-80cf-afbc42160109
bp-28f48d1f-bbaf-405f-8d45-104c52160109

I see the places.sqlite-wal file grow to 400MB and crashes, tried twice.
I don't see dataloss.

Comment 11

[makondo]

I've spent a lot of time researching the cause of my crashes in nightly 47 and release 43/44. Every time i exit (or restart with an extension), it hangs (by 'it' i mean both, nightly and release) and then crash report window shows.
I created numerous profiles, reinstalled both clean twice! with the same result. Was thinking it was something on my computer (using Vista, no problems other that this one) but this last time i decided to check every step i take. It's a clean Nighty of today. I always started with setting Options. I restarted after every little change. As soon as i checked Clear Search and Form history, Nightly hung and crash report showed up. I UNchecked the option and it restarted fine. I checked the option and ... yes, it hung again.
Here's what i see under 'App Notes' in about:crashes:

AdapterVendorID: 0x10de, AdapterDeviceID: 0x104a, AdapterSubsysID: 26163842, AdapterDriverVersion: 10.18.13.6175
FP(D000-L100000-W00000000-T0000) D2D1.1? D2D1.1- D3D11 Layers? D3D11 Layers+ xpcom_runtime_abort([Parent 4788] ###!!! ABORT: file chrome://browser/content/sanitize.js, line 787)

I see conversation above about large/small history. This is a new clean install and i had 1 AMO tab open and 1 userstyles.org forum, i had Options and Addons manager tabs open + those 2 default tabs that open on fresh nightly install where closed. That's it, doesn't seem like a lot of history would accumulate from this. I had the same result before right off the start, that is 2 default tabs and Options tab.

My crashes here:
the last one: https://crash-stats.mozilla.com/report/index/d2874899-bc27-410d-b8bb-bc6f72160219
https://crash-stats.mozilla.com/report/index/c67bff59-32f2-4d01-9305-cee322160219
https://crash-stats.mozilla.com/report/index/7a9d7043-bc14-4918-9ecc-d30f72160219

Comment 12

[Marco Bonardo [:mak]]

(In reply to makondo from comment #11)
>  As soon as i checked Clear
> Search and Form history, Nightly hung and crash report showed up. I
> UNchecked the option and it restarted fine. I checked the option and ...
> yes, it hung again.

Bug 1244650 may help, it should be fixed in firefox 45 beta 7, that will be available in a few days.

Comment 13

[Marco Bonardo [:mak]]

Are you still hanging with today's Nightly? I'm looking for help/steps to reproduce these hangs and finally figure out what's up.
The big history problem is likely bug 871908.

For now I'm excluding the issue with big history, I care about cases where we hang even with a small history or with clear history on shutdown set (so history is just for the session).

Any help is appreciated.

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I suspect that raising crashes in Nightly in [@ mozalloc_abort | NS_DebugBreak | nsDebugImpl::Abort ] is caused either by:
- Bug 1243779 - Remove uriIsPrefix option from nsINavHistoryQuery
- Bug 1220654 - Replace removeVisitsTimeframe with History.removeVisitsByFilter and deprecate it
- Bug 529899 - Session Restore needs to honor "Keep cookies until I close Firefox" in a clean shut-down
as it started to occur always in 47.0a1 (2016-02-18)

Comment 15

[Marco Bonardo [:mak]]

it's probably the effect of bug 1244650 that made us properly wait on shutdown :(
I'm investigating this on Beta.

Comment 16

[Marco Bonardo [:mak]]

bug 1250363 should have helped here.

Comment 17

[Marco Bonardo [:mak]]

I think this has been fixed with bug 1250424.