Closed Bug 1206567 Opened 5 years ago Closed 5 years ago

FFmpeg decoder will crash should we failed to create decoder

Categories

(Core :: Audio/Video: Playback, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1206568
Tracking Status
firefox43 --- affected

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

There are two reasons for this:

1- If FFmpeg failed to create a decoder ; and a function such as Drain is called : it will cause a null deref.
2- The MediaFormatReader attempts to flush / drain the decoder even when we failed to create one.
Assignee: nobody → jyavenard
Comment on attachment 8663501 [details] [diff] [review]
Prevent potential null deref when flushing decoder.

no wonder you had conflict ; the r? wasn't set :(
Attachment #8663501 - Flags: review?(cpearce)
Going to merge this bug with bug 1206568 as I don't want to wait and it also fixed the issue (albeit differently)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1206568
Attachment #8663501 - Attachment is obsolete: true
Attachment #8663501 - Flags: review?(cpearce)
You need to log in before you can comment on or make changes to this bug.