120686 - showdependencygraph.cgi does not allow multiple bugs in 'id'

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[John Vandenberg]

showdependencygraph.cgi prompts the user to enter multiple bug numbers, however
on sumbit it complains "The bug number is invalid. If you are trying to use
QuickSearch, you need to enable JavaScript in your browser. To help us fix this
limitation, look here."

Comment 1

[John Vandenberg]

Attachment: fix

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 65536 [details] [diff] [review]
fix

You should (re)move the SECURITY VALIDATION comments, since you aren't doing
the tests there.

Comment 3

[John Vandenberg]

Attachment: v2: removes block markers

I have removed them, as they would look unusual moved, and using ValidateBugID
is common practise now from what I have seen.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 65556 [details] [diff] [review]
v2: removes block markers

r=bbaetz. This is OK. I don't have graphing working properly on my machine
(pseudo NAT) - 2nd reviewer should test.

An '|| next' after the validation is probably better style, but it doesn't
matter given the structure of that loop.

Comment 5

[Gervase Markham [:gerv]]

Reassigning to zeroJ.

Gerv

Comment 6

[Gervase Markham [:gerv]]

*** Bug 107751 has been marked as a duplicate of this bug. ***

Comment 7

[Gervase Markham [:gerv]]

The templatisation (bug 126793) does, indeed, fix this.

Gerv

Comment 8

[John Vandenberg]

Fixed by bug 126793.