1206882 - Merge back the action row to the location bar input field

Status: RESOLVED DUPLICATE of bug 1235397

(Firefox :: Address Bar, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Whenever the unified autocomplete is enabled the search results are always shown even if they have been turned off via the preference.

Steps:
1. Download Firefox Dev Edition 43.0a2 from Sep 21 with unified complete turned on
2. Enter a search term into the location bar

Expected results:
Do not see a line with the magnification glass for a search result

Current results:
An extra line for search results.

If you turn off unifiedcomplete ('browser.urlbar.unifiedcomplete') all works fine again. But only with it enabled, search suggestions cannot be disabled via 'browser.urlbar.suggest.searches'=false

We never noticed that with our Firefox UI Tests given that unifiedcomplete was turned off all the time for Aurora.

Maybe this is present since bug 959594 got fixed? I will do a regression test.

Comment 1

[Drew Willcoxon :adw]

Are you talking about the single "Search with" item that appears as the first result?  That's expected.  That's part of UnifiedComplete.  Search suggestions are entirely different.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, it's about the first item in that list. I was a bit surprised while investigating the test failure on bug 1206833 and seeing that in Aurora builds now. 

So there is really no way to disable that entry? Personally it bugs me a lot given that it breaks muscle memory when quickly accessing most used sites as listed in the auto-complete list.

Comment 3

[Drew Willcoxon :adw]

Unfortunately not.  It's part of the interaction design of UnifiedComplete.  Might be worth filing a feature-request bug though because you can imagine that lots of people would feel the same way.  There may be such a bug already, I don't know because I haven't been working on UnifiedComplete for very long.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I think that this bug is perfectly covering that. Maybe we might have to adjust the summary. Regarding a possible existing bug I assume that Marco will know about it.

Comment 5

[Marco Bonardo [:mak]]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> So there is really no way to disable that entry? Personally it bugs me a lot
> given that it breaks muscle memory when quickly accessing most used sites as
> listed in the auto-complete list.

no, it doesn't break muscle memory since it's preselected, if you blindly execute the same actions as before, you'll end up with the same exact result. UnifiedComplete has been built in a way to not change the previous behavior and not break muscle memory.

The problem you are having here is that it activates peripheral vision, cause now something is explaining what you are doing and that thing it selected (likely blu). So you end up putting more attention than before, the first times use use it. But currently all of the top browsers are doing this same exact thing. It affects us cause we were different before.

The longest term plan is to eventually merge back the action row to the input field, but there's no ETA for that. I'm morphing the title to that.