1223728 - Remove the unifiedcomplete pref and the urlinline component

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Once unifiedcomplete is released, we can remove the unifiedcomplete pref, all the code supporting it and the old urlinline component plus its tests.

This code is unmaintained but it's being used in the wild, plus supporting on-the-fly switch of autocomplete engines adds work we can avoid.

for now we'll retain the history autocomplete component since it's used by Seamonkey, we can move it to suite in a separate bug.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we can also evaluate removing support for typeAheadResult in toolkit/autocomplete, it adds quite some complication to the controller code and it existed only for urlinline, that means undoing most of http://hg.mozilla.org/mozilla-central/rev/51dcdc85081c

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

let's make this depend on bug 1206882, we may decide to do this sooner but it should be clear the most common complain is that bug.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think we should move on with this, with the new style the old implementation starts being unmaintained, and someone prefers to disable the feature rather than reporting bugs and improvement requests.
This will also force us to really concentrate on issues and solve them.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

since the option is currently broken with the new redesign, we should probably speed up its removal.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review commit: https://reviewboard.mozilla.org/r/50601/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50601/

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ok, there are some failures to handle on Try.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/1-2/

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/2-3/

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/3-4/

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

There are a couple do_print I wrongly inserted into browser-chrome (browser_tabMatchesInAwesomebar.js and browser_599909.js), that I fixed locally. At the moment I have a ticket open cause my commit access is broken, so I cannot update the patch.

Apart from that the other tests look good.

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96c42b391e4d906771d7b2f0d5144ad2045ee135

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

https://reviewboard.mozilla.org/r/50601/#review47921

Very nice!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/44a989cf6c16

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44a989cf6c16

Comment 15

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1223728 - Remove the unifiedcomplete pref.

Review commit: https://reviewboard.mozilla.org/r/59416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59416/

Comment 16

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8763084 [details]
Bug 1223728 - Remove the unifiedcomplete pref.

Wrong bug number.