Closed Bug 1223728 Opened 4 years ago Closed 4 years ago

Remove the unifiedcomplete pref and the urlinline component

Categories

(Toolkit :: Places, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox45 --- affected
firefox49 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch][unifiedcomplete])

Attachments

(1 file, 1 obsolete file)

Once unifiedcomplete is released, we can remove the unifiedcomplete pref, all the code supporting it and the old urlinline component plus its tests.

This code is unmaintained but it's being used in the wild, plus supporting on-the-fly switch of autocomplete engines adds work we can avoid.

for now we'll retain the history autocomplete component since it's used by Seamonkey, we can move it to suite in a separate bug.
we can also evaluate removing support for typeAheadResult in toolkit/autocomplete, it adds quite some complication to the controller code and it existed only for urlinline, that means undoing most of http://hg.mozilla.org/mozilla-central/rev/51dcdc85081c
let's make this depend on bug 1206882, we may decide to do this sooner but it should be clear the most common complain is that bug.
Depends on: 1206882
Priority: P2 → P3
Summary: Remote the unifiedcomplete pref and the urlinline component → Remove the unifiedcomplete pref and the urlinline component
I think we should move on with this, with the new style the old implementation starts being unmaintained, and someone prefers to disable the feature rather than reporting bugs and improvement requests.
This will also force us to really concentrate on issues and solve them.
Priority: P3 → P2
since the option is currently broken with the new redesign, we should probably speed up its removal.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
ok, there are some failures to handle on Try.
Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/1-2/
Attachment #8748904 - Attachment description: MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=adw → MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=
Attachment #8748904 - Flags: review?(adw)
Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/2-3/
Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50601/diff/3-4/
Attachment #8748904 - Flags: review?(adw)
There are a couple do_print I wrongly inserted into browser-chrome (browser_tabMatchesInAwesomebar.js and browser_599909.js), that I fixed locally. At the moment I have a ticket open cause my commit access is broken, so I cannot update the patch.

Apart from that the other tests look good.
Comment on attachment 8748904 [details]
MozReview Request: Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component. r=

https://reviewboard.mozilla.org/r/50601/#review47921

Very nice!
Attachment #8748904 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/44a989cf6c16
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Blocks: 1267678
Depends on: 1271738
Depends on: 1279425
Attachment #8748904 - Attachment is obsolete: true
Comment on attachment 8763084 [details]
Bug 1223728 - Remove the unifiedcomplete pref.

Wrong bug number.
Attachment #8763084 - Flags: review?(adw)
Depends on: 1291361
Depends on: 1303608
You need to log in before you can comment on or make changes to this bug.