Closed
Bug 1206918
Opened 10 years ago
Closed 10 years ago
remove sqlalchemy requirement
Categories
(support.mozilla.org :: Code Quality, task)
support.mozilla.org
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
The requirements/default.txt list lists:
# sha256: xDk0Lw5v1G9WRDHJrksEoAiIlyFCZeLRjUGugY09b_E
sqlalchemy==0.6.4
Two things:
1. That's a really old version of sqlalchemy.
2. Why are we installing that anyhow since we use the django orm?
We should look into why it's being installed and do what we can to remove it. If we can't remove it, we should update it.
| Assignee | ||
Comment 1•10 years ago
|
||
I poked around to see what added sqlalchemy and it looks like it's been around since before 2011. I looked at what code requires it and I'm pretty sure nothing requires it.
I vote we nix it.
In a PR: https://github.com/mozilla/kitsune/pull/2656
Assignee: nobody → willkg
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•10 years ago
|
||
Landed in master: https://github.com/mozilla/kitsune/commit/c7e884d7c1ce05b6d02449b62c873207408ddd1b
We don't need to push anything out here, so I'm marking it FIZIXED!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•