1207131 - (Gaia RTL 2.5) CSS refactoring: update the linter

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fabien Cazenave [:kaze]]

In order to use the new *-inline-{start,end} CSS properties, we need to update the linter.

This will also require to either:
 • use a Gecko 41+ SDK to build Gaia (B2G_SDK_VERSION)
 • or toggle the `layout.css.vertical-text.enabled` preference

Comment 1

[Fabien Cazenave [:kaze]]

Regarding the build tools, it seems that in bug 1146713 there was a pull request to use Gecko 43:

https://github.com/mozilla-b2g/gaia/pull/31847

Ricky, do you still expect to upgrade the build system to Gecko 43?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug-1207131 > mozilla-b2g:master

Comment 3

[pelloux]

Attachment: css linter: add *-inline-start/end support

Comment 4

[Ricky Chien [:rickychien] (inactive)]

As far as I know, build system only need b2g's JavaScript run-time to execute build scripts but it doesn't rely on any css features.

bug 1146713 is dealing with upgrading to gecko 43, it's still causing failures on CI server. We're working on that and I hope we're able to sort it out as soon as possible.

Comment 5

[pelloux]

(In reply to Ricky Chien [:rickychien] from comment #4)
> As far as I know, build system only need b2g's JavaScript run-time to
> execute build scripts but it doesn't rely on any css features.
> 
> bug 1146713 is dealing with upgrading to gecko 43, it's still causing
> failures on CI server. We're working on that and I hope we're able to sort
> it out as soon as possible.

Oh, my bad. I did update locally to gecko 43 and I didn't realized that the linter patch isn't needed anymore.

Comment 6

[Fabien Cazenave [:kaze]]

Thanks for the explanation Ricky. I’ve just added bug 1146713 as a dependency.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

(In reply to Ricky Chien [:rickychien] from comment #4)
> As far as I know, build system only need b2g's JavaScript run-time to
> execute build scripts but it doesn't rely on any css features.

There are some misunderstandings here. As above comment mentioned, b2g_sdk is using for building gaia through gecko's JavaScript run-time. We don't launch it as a simulator to run ffos webapps. If you want to get new feature of gecko 41, you could try to download b2g manually or through WebIDE. So I think it doesn't make sense to depend on bug 1146713.

Comment 8

[Fabien Cazenave [:kaze]]

(In reply to Ricky Chien [:rickychien] from comment #7)
> There are some misunderstandings here. As above comment mentioned, b2g_sdk
> is using for building gaia through gecko's JavaScript run-time. We don't
> launch it as a simulator to run ffos webapps.

To my understanding, the result of a `make lint` depends on the b2g_sdk version. As we’re using CSS properties that depend on Gecko 41+ [1][2], the current b2g_sdk version 39 raises CSS lint errors, thus blocking all our current patches. Example: [3]

Of course, if there are other ways to make the CSS linter accept these properties [1], we’re fine too. Otherwise I’d prefer to depend on bug 1146713, or create another bug specifically for the Gecko upgrade and make this bug and bug 1146713 depend on it. WDYT?

[1] {margin,padding,border,offset}-inline-{start,end}
[2] https://wiki.mozilla.org/Gaia/CSS_Guidelines#Use_direction-sensitive_rules
[3] https://github.com/mozilla-b2g/gaia/pull/31971

Comment 9

[Ricky Chien [:rickychien] (inactive)]

ok, it seems that css parser is built-in in inIDOMUtils [1] so it makes sense to upgrade to newer gecko.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/inIDOMUtils#parseStyleSheet%28%29

Comment 10

[Ricky Chien [:rickychien] (inactive)]

However, I feel fine to put them in build/csslint/xfails.list to skip it since it's an experimental / un-stabilized properties at the time.

Comment 11

[Julien Wajsberg [:julienw]]

(In reply to Ricky Chien [:rickychien] from comment #10)
> However, I feel fine to put them in build/csslint/xfails.list to skip it
> since it's an experimental / un-stabilized properties at the time.

These properties are fairly stabilized now.

Comment 12

[Sam Foster [:sfoster] (he/him)]

It doesnt look like we'll get this on 2.5; unblocking 1179459

Comment 13

[BMO Automation]

Firefox OS is not being worked on