Closed Bug 1207103 Opened 6 years ago Closed 6 years ago

(Gaia RTL 2.5) CSS refactoring: value selectors

Categories

(Firefox OS Graveyard :: Gaia::Shared, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
feature-b2g 2.5+

People

(Reporter: u550245, Assigned: kaze)

References

Details

Attachments

(1 file, 2 obsolete files)

46 bytes, text/x-github-pull-request
pivanov
: review+
Details | Review
Improve the RTL support of the System app by refactoring the stylesheets for these building blocks:

 • date_selector
 • time_selector
 • value_selector
Attached file CSS refactoring (obsolete) —
Hey Pavel, :-)

most of this patch should be a straight-forward CSS refactoring, to match our BiDi guidelines [1]. Main points worth noticing:
 • time_selector, there was a typo in the `12hrev` format that had to be fixed in a couple JS files (trivial fix);
 • date_selector, I’ve had to redo a rather big part of the stylesheet.

The date and time selectors aren’t just about mirroring rules from LTR to RTL, as some parts remain at the same position whatever the language direction is.
Attachment #8664178 - Flags: review?(pivanov)
Assignee: nobody → kaze
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached file CSS refactoring
Ooops, I posted this patch with the wrong bugzilla account. Sorry.
Attachment #8664177 - Attachment is obsolete: true
Attachment #8664178 - Attachment is obsolete: true
Attachment #8664178 - Flags: review?(pivanov)
Attachment #8664183 - Flags: review?(pivanov)
Blocks: 1207131
I left few comments in github ... but everything else looks good :) thanks r+
Attachment #8664183 - Flags: review?(pivanov) → review+
feature-b2g: --- → 2.5+
Comments addressed, commits squashed. Thanks Pavel! :)
Kazé,
Are we waiting for bug 1207131 to land this and similar bugs that have non-green tests?
Blocks: 1208170
No longer blocks: 1208170
No longer blocks: 1207131
Merged on master: https://github.com/mozilla-b2g/gaia/commit/405c72c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1211421
Blocks: 1208170
Blocks: 1213057
Blocks: 1215095
No longer blocks: 1215095
Blocks: 1216066
Blocks: 1216068
You need to log in before you can comment on or make changes to this bug.