(Gaia RTL 2.5) CSS refactoring: value selectors

RESOLVED FIXED

Status

Firefox OS
Gaia::Shared
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u550245, Assigned: kaze)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.5+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

46 bytes, text/x-github-pull-request
ivanovpavel
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
Improve the RTL support of the System app by refactoring the stylesheets for these building blocks:

 • date_selector
 • time_selector
 • value_selector

Comment 1

2 years ago
Created attachment 8664177 [details] [review]
[gaia] fabi1cazenave:bb-value-selector > mozilla-b2g:master
(Reporter)

Comment 2

2 years ago
Created attachment 8664178 [details] [review]
CSS refactoring

Hey Pavel, :-)

most of this patch should be a straight-forward CSS refactoring, to match our BiDi guidelines [1]. Main points worth noticing:
 • time_selector, there was a typo in the `12hrev` format that had to be fixed in a couple JS files (trivial fix);
 • date_selector, I’ve had to redo a rather big part of the stylesheet.

The date and time selectors aren’t just about mirroring rules from LTR to RTL, as some parts remain at the same position whatever the language direction is.
Attachment #8664178 - Flags: review?(pivanov)
Blocks: 1202354
(Assignee)

Updated

2 years ago
Assignee: nobody → kaze
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

2 years ago
Created attachment 8664183 [details] [review]
CSS refactoring

Ooops, I posted this patch with the wrong bugzilla account. Sorry.
Attachment #8664177 - Attachment is obsolete: true
Attachment #8664178 - Attachment is obsolete: true
Attachment #8664178 - Flags: review?(pivanov)
Attachment #8664183 - Flags: review?(pivanov)
(Assignee)

Updated

2 years ago
Blocks: 1207131
I left few comments in github ... but everything else looks good :) thanks r+
Attachment #8664183 - Flags: review?(pivanov) → review+

Updated

2 years ago
feature-b2g: --- → 2.5+
(Assignee)

Comment 5

2 years ago
Comments addressed, commits squashed. Thanks Pavel! :)
Kazé,
Are we waiting for bug 1207131 to land this and similar bugs that have non-green tests?
(Assignee)

Updated

2 years ago
Blocks: 1208170
(Assignee)

Updated

2 years ago
No longer blocks: 1208170
(Assignee)

Updated

2 years ago
No longer blocks: 1207131
(Assignee)

Comment 7

2 years ago
Merged on master: https://github.com/mozilla-b2g/gaia/commit/405c72c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1211421
(Assignee)

Updated

2 years ago
Blocks: 1208170
(Assignee)

Updated

2 years ago
Blocks: 1213057

Updated

2 years ago
Blocks: 1215095

Updated

2 years ago
No longer blocks: 1215095

Updated

2 years ago
Blocks: 1216066

Updated

2 years ago
Blocks: 1216068
You need to log in before you can comment on or make changes to this bug.