1207103 - (Gaia RTL 2.5) CSS refactoring: value selectors

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[u550245]

Improve the RTL support of the System app by refactoring the stylesheets for these building blocks:

 • date_selector
 • time_selector
 • value_selector

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] fabi1cazenave:bb-value-selector > mozilla-b2g:master

Comment 2

[u550245]

Attachment: CSS refactoring

Hey Pavel, :-)

most of this patch should be a straight-forward CSS refactoring, to match our BiDi guidelines [1]. Main points worth noticing:
 • time_selector, there was a typo in the `12hrev` format that had to be fixed in a couple JS files (trivial fix);
 • date_selector, I’ve had to redo a rather big part of the stylesheet.

The date and time selectors aren’t just about mirroring rules from LTR to RTL, as some parts remain at the same position whatever the language direction is.

Comment 3

[Fabien Cazenave [:kaze]]

Attachment: CSS refactoring

Ooops, I posted this patch with the wrong bugzilla account. Sorry.

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I left few comments in github ... but everything else looks good :) thanks r+

Comment 5

[Fabien Cazenave [:kaze]]

Comments addressed, commits squashed. Thanks Pavel! :)

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

Kazé,
Are we waiting for bug 1207131 to land this and similar bugs that have non-green tests?

Comment 7

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/405c72c