1207166 - Hover on tab sound visual indicator overlaps the pinned tabs border

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Reproduced with Firefox 42 beta 1 and latest Nightly 44.0a1 2015-09-22 across platforms. 

STR:
1. Open https://www.youtube.com and play a video so that the tab sound icon is displayed.
2. Pin the tab
3. Hover the sound visual indicator in both mute and unmute states

ER: The icon shouldn't overlap the tab 

AR: The icon slightly overlaps the tab border: http://i.imgur.com/LzZOMFz.png

Comment 1

[(no longer active)]

Attachment: Screenshot

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

Comment on attachment 8664849 [details] [diff] [review]
Patch (v1)

Looks like I forgot to ask for review!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8664849 [details] [diff] [review]
Patch (v1)

Review of attachment 8664849 [details] [diff] [review]:
-----------------------------------------------------------------

This still overlaps the pinned tab border for me. I see a second "hump" at the top of the tab. Shouldn't the margin-start become *more* negative, and the margin-top stay the same or *less* negative? Screenshot, http://screencast.com/t/KCkCDhiif

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

So after looking at this again, on a pixel level there does not appear to be a second "hump", but cognitively the extra weight of the white background color provides a strong anchor near the icon which gives an illusion of a second hump. I think moving it down one pixel and left one pixel will reduce this illusion.

Maybe margin-top:-8px, margin-inline-start:-15px ?

Comment 6

[(no longer active)]

Comment on attachment 8664849 [details] [diff] [review]
Patch (v1)

OK, can you review assuming |margin-top:-8px, margin-inline-start:-15px|?  ;-)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8664849 [details] [diff] [review]
Patch (v1)

Review of attachment 8664849 [details] [diff] [review]:
-----------------------------------------------------------------

sure, rs=me

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/431c8dcb9039

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/431c8dcb9039

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Mac OSX 10.9.5 and Ubuntu 13.10 32bit using Firefox 44 Beta 2 (buildID: 20151221151411).