1223839 - Sound indicator increases pinned tab content's width by 1px

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[arni2033]

STR:   (Win7_64, Nightly 45, 32bit, ID 20151108030417, new profile)
1. Open new window, open 2 tabs in that window, pin active tab
2. Press Ctrl+M so that tab displayed "Muted" sound indicator

Result:
 Right ugly-curved tab border AND all other tabs AND new tab button [+] teleports to the right by 1px

Expectations:
 They should stay still = pinned tab content's width shouldn't increase.

Note:
 Please request a screencast if you can't reproduce this yourself.
 I experience this very often, because I have https://vk.com/ loaded in the 1st pinned tab.
 VK.com is russian social network that uses sound notifications about new messages, so all tabs twitch

Comment 1

[arni2033]

Oh. I forgot about regression window:
>   https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=00ac696cdc862aad8fb2bc742ad11b6ce3d1559e&tochange=431c8dcb9039036aa11c8d2b361ab354bb98f2fd

Comment 2

[arni2033]

I think that .tab-icon-overlay[muted] should have "margin-inline-end: -1px;" - works for me.
>   .tab-icon-overlay[muted]{
>     margin-inline-end: -1px;
>   }

Comment 3

[arni2033]

I think that .tab-icon-overlay should have "margin-inline-end: -1px;" - works for me.
>   .tab-icon-overlay{
>     margin-inline-end: -1px;
>   }

Comment 4

[Doug Turner (:dougt)]

ehsan, can you take a look or find an owner please?

Comment 5

[(no longer active)]

Attachment: Avoid expanding the width of a pinned tab when displaying the overlay icon

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8728136 [details] [diff] [review]
Avoid expanding the width of a pinned tab when displaying the overlay icon

Review of attachment 8728136 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, would be nice to get this uplifted to aurora as it's a simple css change.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecfe8eaa0ea7

Comment 8

[(no longer active)]

Comment on attachment 8728136 [details] [diff] [review]
Avoid expanding the width of a pinned tab when displaying the overlay icon

Approval Request Comment
[Feature/regressing bug #]: Bug 1207166
[User impact if declined]: comment 0
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: simple css change, risk free
[String/UUID change made/needed]: none

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecfe8eaa0ea7

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8728136 [details] [diff] [review]
Avoid expanding the width of a pinned tab when displaying the overlay icon

Simple enough, taking it.

Comment 11

[arni2033]

Fixed on:   Win7_64, Nightly 48, 32bit, ID 20160310030242

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f28fdbf2af28

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e3808c5487e1

Comment 14

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I've managed to reproduce the bug on the affected builds, using Windows 10 x64.

This is verified fixed on:
- 46.0b2-build3 (20160316065941),
- 47.0a2 (2016-03-15),
- 48.0a1 (2016-03-15),
using Windows 10 x64, Windows 7 x64, Ubuntu 12.04 (x86) and Mac OS X 10.7.