Closed Bug 1207307 Opened 4 years ago Closed 4 years ago

Remove MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES flag

Categories

(Firefox for Android :: Android Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: vivek, Assigned: martianwars, Mentored)

References

(Blocks 1 open bug)

Details

User Story

This is the final task for fennec-avatar. Remove the flag and related code once the avatar is available in Fennec main branch.

Attachments

(1 file)

No description provided.
User Story: (updated)
@Kalpesh,
This is another bug related to sync preferences.
Let me know if you are interested in this.

Now that profile preference is in Beta, we can start removing the flag [1].
Also, we can remove the code related to emailPreference from FxAccountStatusFragment and the relevant preference declaration in xml [2],[3].

To summarize, 
* remove the MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES from [1]. 
* remove emailPreference while retaining profilePreference in [2]
* remove email preference declaration from [3]


[1] http://mxr.mozilla.org/mozilla-central/search?string=MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/activities/FxAccountStatusFragment.java#170
[3] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/fxaccount_status_prefscreen.xml#14
Flags: needinfo?(kalpeshk2011)
@vivek :- I need to remove all the occurrences of the AppConstant? What will I put in place of that?
Flags: needinfo?(kalpeshk2011) → needinfo?(vivekb.balakrishnan)
@Kalpesh,

You need to remove all occurrences of AppConstants.MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES. It is usually used as Boolean condition. Retain the code snippet that is executed when the flag is true. You can throw away the code snippet in false branch.

Also, note that AppConstants.java is generated during build process from AppConstants.java.in [1]

Please let me know if this was not clear.


[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AppConstants.java.in#202
Flags: needinfo?(vivekb.balakrishnan)
@vivek :- alright, I'll work on this one :)
Assignee: nobody → kalpeshk2011
I hope it removes all occurrences of the AppConstant.
Attachment #8682395 - Flags: review?(vivekb.balakrishnan)
Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Kalpesh,

thanks, this patch removes all occurrences of MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES flag.
I'll update the review flag after I test this patch.
Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Tested it. LGTM
Attachment #8682395 - Flags: review?(vivekb.balakrishnan)
Attachment #8682395 - Flags: review?(nalexander)
Attachment #8682395 - Flags: review+
Alright that's excellent :)
Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Good work!
Attachment #8682395 - Flags: review?(nalexander) → review+
Should I add the checkin needed?
Flags: needinfo?(nalexander)
@vivek, What could I work on next?
Flags: needinfo?(vivekb.balakrishnan)
https://hg.mozilla.org/mozilla-central/rev/0159a6e6438e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Commented on bug 1208759
Flags: needinfo?(vivekb.balakrishnan)
(In reply to Kalpesh Krishna [:martianwars] from comment #10)
> Should I add the checkin needed?

I landed this for you, so no need.
Flags: needinfo?(nalexander)
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.