1207307 - Remove MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Comment 1

[Vivek Balakrishnan[:vivek]]

@Kalpesh,
This is another bug related to sync preferences.
Let me know if you are interested in this.

Now that profile preference is in Beta, we can start removing the flag [1].
Also, we can remove the code related to emailPreference from FxAccountStatusFragment and the relevant preference declaration in xml [2],[3].

To summarize, 
* remove the MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES from [1]. 
* remove emailPreference while retaining profilePreference in [2]
* remove email preference declaration from [3]


[1] http://mxr.mozilla.org/mozilla-central/search?string=MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/activities/FxAccountStatusFragment.java#170
[3] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/fxaccount_status_prefscreen.xml#14

Comment 2

[Kalpesh Krishna [:martianwars]]

@vivek :- I need to remove all the occurrences of the AppConstant? What will I put in place of that?

Comment 3

[Vivek Balakrishnan[:vivek]]

@Kalpesh,

You need to remove all occurrences of AppConstants.MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES. It is usually used as Boolean condition. Retain the code snippet that is executed when the flag is true. You can throw away the code snippet in false branch.

Also, note that AppConstants.java is generated during build process from AppConstants.java.in [1]

Please let me know if this was not clear.


[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AppConstants.java.in#202

Comment 4

[Kalpesh Krishna [:martianwars]]

@vivek :- alright, I'll work on this one :)

Comment 5

[Kalpesh Krishna [:martianwars]]

Attachment: removeAppConstant.patch

I hope it removes all occurrences of the AppConstant.

Comment 6

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Kalpesh,

thanks, this patch removes all occurrences of MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES flag.
I'll update the review flag after I test this patch.

Comment 7

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Tested it. LGTM

Comment 8

[Kalpesh Krishna [:martianwars]]

Alright that's excellent :)

Comment 9

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8682395 [details] [diff] [review]
removeAppConstant.patch

Review of attachment 8682395 [details] [diff] [review]:
-----------------------------------------------------------------

Good work!

Comment 10

[Kalpesh Krishna [:martianwars]]

Should I add the checkin needed?

Comment 11

[Kalpesh Krishna [:martianwars]]

@vivek, What could I work on next?

Comment 12

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/0159a6e6438e916708c988fc96b02225c7974ffc
Bug 1207307 - Remove MOZ_ANDROID_FIREFOX_ACCOUNT_PROFILES flag. r=vivek,nalexander

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0159a6e6438e

Comment 14

[Vivek Balakrishnan[:vivek]]

Commented on bug 1208759

Comment 15

[Nick Alexander :nalexander [he/him]]

(In reply to Kalpesh Krishna [:martianwars] from comment #10)
> Should I add the checkin needed?

I landed this for you, so no need.