1207545 - Inconsistency between the steps from tracking protection UITour

Status: VERIFIED FIXED

(Firefox :: Tours, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: steps diff.png

Reproduced with Firefox 42 beta 1, latest Aurora 43.0a2 2015-09-23 and latest Nightly 44.0a1 2015-09-22 under Win 7 64-bit, Ubuntu 14.04 and Mac OS X 10.9.5.

STR:
1. Open a private window and select "See how this works" button to start the tracking protection tour - https://www.mozilla.org/en-US/firefox/44.0a1/tracking-protection/start/
2. Notice the styling of the first step and then select Next to go to the second one

ER: All the three steps from the tour have the same styling

AR: Step 2 is different from steps 1 and 3:
- different font used (eg for Win: Helvetica (bold) instead of Lucinda Grande (bold))
- the Next button is slightly smaller
- Next text has a different (or smaller) font
- X button to close the tooltip has a different style and background icon

Comment 1

[Alex Gibson [:agibson]]

Thanks for filing this,

The info panel on step 2 of the TP tour isn't in fact a real XUL panel. We can't target them on content in the web page itself, so for step 2 we recreated one using HTML/CSS. This is why they look a bit different.

I can work on this and try and make it as close as possible. I'm comforted by the fact this was down as blocking Bug 1207419, which shows we must be at least close :)

Comment 2

[Alex Gibson [:agibson]]

Matt, a few styling questions for the info panel on step 2:

1.) I'm currently using `font: -moz-document;` for the info panel. Should I be using something else to make sure it matches the real XUL panels? `font: message-box` perhaps?

2.) Can you help point me to the CSS for the actual panels, so I can try and match things as close as possible.

3.) I'm also trying to locate the image(s) used for the beveled (x) close button.

Thanks!

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Removing these bugs as blockers for the release of the Tracking Protection UITour for the Fall.

Any UITour position-related bugs should be tied to bug 1207419.

Comment 4

[Matthew N. [:MattN]]

As discussed today:
https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/UITour.inc.css
https://mxr.mozilla.org/mozilla-central/search?string=UITourTooltip&find=\.css&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

plus using the devtools on the browser are useful.

Images are from:
https://mxr.mozilla.org/mozilla-central/find?string=icons%2Fclose.png&tree=mozilla-central&hint=

Comment 5

[Alex Gibson [:agibson]]

Closing this, as was fixed in Bug 1209429. We added separate button styles for Windows, OSX and Linux for the step 2 door-hanger, as per Comment 4. It may not be pixel-perfectly identical, but we agreed it wasn't worth spending too much time on.