Closed
Bug 1207594
Opened 9 years ago
Closed 9 years ago
Drop a link on tab bar doesn't work
Categories
(Core :: DOM: Copy & Paste and Drag & Drop, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
firefox42 | --- | affected |
firefox43 | --- | affected |
firefox44 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: krzysztof.glebowicz, Assigned: enndeakin)
References
Details
(Keywords: regression, Whiteboard: [dupe me])
Attachments
(1 file)
9.97 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:43.0) Gecko/20100101 Firefox/43.0 Build ID: 20150831030209 Steps to reproduce: 1. Open new page in a text editor (Notepad++). 2. Past there any link, for instance http://goo.gl, then select this link. 3. Try to drag&drop this link on a tab bar, between tabs (as a new tab) or on any tab. Actual results: I see an up-arrow icon (this doesn't dissapear) and a crossed circle. The link is not opening. Expected results: The link should have been opened.
Yes, I filed a similar bug (bug 1207634) with details. Surely a dupe.
Component: Untriaged → Drag and Drop
Product: Firefox → Core
Comment 2•9 years ago
|
||
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=44986f66ee4b&tochange=8c81e97e0604 Regressed by: Bug 1121946
Blocks: 1121946
Status: UNCONFIRMED → NEW
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox43:
--- → affected
status-firefox44:
--- → unaffected
status-firefox-esr38:
--- → unaffected
Ever confirmed: true
Keywords: regression
Whiteboard: [dupe me]
Assignee | ||
Comment 4•9 years ago
|
||
I originally posted an earlier version of this patch in bug 1207634. This issue here is that the drag data only allows 'move' and 'copy' but the tabbar sets the drop effect to 'link'. 'link' is intended to be used to create a link to the original data which perhaps is an abstract way of thinking about dropping links onto the tabbar, but other applications don't seem to think that way. So this patch doesn't set the dropEffect or effectAllowed within the dragover event.
Assignee: nobody → enndeakin
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Attachment #8677492 -
Flags: review?(dao)
Updated•9 years ago
|
Attachment #8677492 -
Flags: review?(dao) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd16953417bee8297fbd412a0654b63c3e98b5d Bug 1207594, don't set dropEffect and effectAllowed in tab bar dragover event, which allows drops of data that aren't links, r=dao
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dcd16953417b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•