Closed Bug 1207594 Opened 4 years ago Closed 4 years ago

Drop a link on tab bar doesn't work

Categories

(Core :: Drag and Drop, defect)

41 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox41 --- affected
firefox42 --- affected
firefox43 --- affected
firefox44 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: krzysztof.glebowicz, Assigned: enndeakin)

References

Details

(Keywords: regression, Whiteboard: [dupe me])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150831030209

Steps to reproduce:

1. Open new page in a text editor (Notepad++).
2. Past there any link, for instance http://goo.gl, then select this link.
3. Try to drag&drop this link on a tab bar, between tabs (as a new tab) or on any tab. 


Actual results:

I see an up-arrow icon (this doesn't dissapear) and a crossed circle. The link is not opening. 


Expected results:

The link should have been opened.
Version: 40 Branch → 41 Branch
Yes, I filed a similar bug (bug 1207634) with details. Surely a dupe.
Component: Untriaged → Drag and Drop
Product: Firefox → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1207634
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
I originally posted an earlier version of this patch in bug 1207634.

This issue here is that the drag data only allows 'move' and 'copy' but the tabbar sets the drop effect to 'link'. 'link' is intended to be used to create a link to the original data which perhaps is an abstract way of thinking about dropping links onto the tabbar, but other applications don't seem to think that way. So this patch doesn't set the dropEffect or effectAllowed within the dragover event.
Assignee: nobody → enndeakin
Status: REOPENED → ASSIGNED
Attachment #8677492 - Flags: review?(dao)
Attachment #8677492 - Flags: review?(dao) → review+
Blocks: 1207634
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd16953417bee8297fbd412a0654b63c3e98b5d
Bug 1207594, don't set dropEffect and effectAllowed in tab bar dragover event, which allows drops of data that aren't links, r=dao
https://hg.mozilla.org/mozilla-central/rev/dcd16953417b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1235129
You need to log in before you can comment on or make changes to this bug.