Closed Bug 1207733 Opened 4 years ago Closed 4 years ago

Remove password button should be disabled when no row is selected

Categories

(Toolkit :: Password Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: rfeeley, Assigned: roland.sako, Mentored)

References

()

Details

(Whiteboard: [lang=js][lang=xul])

Attachments

(1 file)

The remove password button should be disabled when no row is selected like it is in the exceptions section.
I should add that the button is disabled when the saved logins are first opened, but that it does not become disabled after all rows are deselected.
Attachment #8675287 - Flags: review?(MattN+bmo)
Assignee: nobody → roland.sako
Status: NEW → ASSIGNED
Comment on attachment 8675287 [details] [diff] [review]
bug-1207733.patch

Review of attachment 8675287 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/content/passwordManager.js
@@ +159,5 @@
>    var selections = GetTreeSelections(signonsTree);
>    if (selections.length) {
>      document.getElementById("removeSignon").removeAttribute("disabled");
>    }
> +  else {

Nit: For the future, this file (and most Mozilla code) cuddles the `else`. I will fix this before pushing.
Attachment #8675287 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/28d85a5f72c3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Roland, congrats on getting your patch landed! Would you be interested in working on bug 1173583 next?
Congrats Roland!!
You need to log in before you can comment on or make changes to this bug.