1207733 - Remove password button should be disabled when no row is selected

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Ryan Feeley [:rfeeley]]

The remove password button should be disabled when no row is selected like it is in the exceptions section.

Comment 1

[Matthew N. [:MattN]]

https://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/content/passwordManager.js
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/content/passwordManager.xul

Comment 2

[Ryan Feeley [:rfeeley]]

I should add that the button is disabled when the saved logins are first opened, but that it does not become disabled after all rows are deselected.

Comment 3

[Roland Sako]

Attachment: bug-1207733.patch

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8675287 [details] [diff] [review]
bug-1207733.patch

Review of attachment 8675287 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/content/passwordManager.js
@@ +159,5 @@
>    var selections = GetTreeSelections(signonsTree);
>    if (selections.length) {
>      document.getElementById("removeSignon").removeAttribute("disabled");
>    }
> +  else {

Nit: For the future, this file (and most Mozilla code) cuddles the `else`. I will fix this before pushing.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/28d85a5f72c3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28d85a5f72c3

Comment 7

[Matthew N. [:MattN]]

Roland, congrats on getting your patch landed! Would you be interested in working on bug 1173583 next?

Comment 8

[Ryan Feeley [:rfeeley]]

Congrats Roland!!