Closed Bug 1207897 Opened 9 years ago Closed 9 years ago

Add a configure option to build multiple build backends

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With bug 1207893, it will be possible to invoke mach build-backend such as to create multiple backends at once. We should allow people to opt-in to more backends in their mozconfig (think opting-in to the eclipse backend)
Also record what backends were requested at configure time so that running
`mach build-backend` or `config.status` uses the same set.
Assignee: nobody → mh+mozilla
Attachment #8665700 - Flags: review?(gps)
Comment on attachment 8665700 [details] [diff] [review]
Add a configure option to build multiple build backends

Review of attachment 8665700 [details] [diff] [review]:
-----------------------------------------------------------------

I'll give r+ despite the comment because I trust you to test things before landing.

::: python/mozbuild/mozbuild/mach_commands.py
@@ +565,1 @@
>      def build_backend(self, backend='RecursiveMake', diff=False):

If `backend` defaults to "RecursiveMake", won't that lead to "--backend R e c u r s i v e M a k e" due to the .extend(backend) below?

Actually, I'm not sure how this worked before, since [] + str == list(iter(str))

Did I miss something in an earlier patch?
Attachment #8665700 - Flags: review?(gps) → review+
No, that's an oversight on my part, the default is meant to be removed (and in fact, considering how the command line handler works, that default in the function definition is actually ignored, aiui).
Depends on: 1209398
https://hg.mozilla.org/mozilla-central/rev/617e63c7c9ae
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: