Closed Bug 1209398 Opened 4 years ago Closed 4 years ago

Enable FasterMake backend by default

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Now that we can have multiple backends enabled at once, considering the small overhead in applying the FasterMake backend and that it works as some sort of sub-target of the recursive make backend, we can add it by default for people to optionally use it with `mach build faster`.
While the name AC_SUBST_SET suggests the underlying type would be a set, it does
not actually matter that much in moz.build, and is not used that much anyways.
Attachment #8667102 - Flags: review?(gps)
The order in which backends appear is important, and dealing with deduplication
in configure.in is not really nice, so for all simplification purposes, this relies
on using AC_SUBST_SET, which does the deduplication and keeps the original order
in which items appear (despite its name).
Attachment #8667104 - Flags: review?(gps)
(In reply to Mike Hommey [:glandium] from comment #0)
> Now that we can have multiple backends enabled at once, considering the
> small overhead in applying the FasterMake backend and that it works as some
> sort of sub-target of the recursive make backend, we can add it by default
> for people to optionally use it with `mach build faster`.

How much is the overhead?
0.1s on my MBP.
Attachment #8667102 - Flags: review?(gps) → review+
Attachment #8667104 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/f878931c06c1
https://hg.mozilla.org/mozilla-central/rev/e5fa86cd2980
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1220323
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.