1209398 - Enable FasterMake backend by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Now that we can have multiple backends enabled at once, considering the small overhead in applying the FasterMake backend and that it works as some sort of sub-target of the recursive make backend, we can add it by default for people to optionally use it with `mach build faster`.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Make AC_SUBST_SET emit a list of unique items instead of an actual set

While the name AC_SUBST_SET suggests the underlying type would be a set, it does
not actually matter that much in moz.build, and is not used that much anyways.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Enable the FasterMake backend by default for desktop Firefox builds

The order in which backends appear is important, and dealing with deduplication
in configure.in is not really nice, so for all simplification purposes, this relies
on using AC_SUBST_SET, which does the deduplication and keeps the original order
in which items appear (despite its name).

Comment 3

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #0)
> Now that we can have multiple backends enabled at once, considering the
> small overhead in applying the FasterMake backend and that it works as some
> sort of sub-target of the recursive make backend, we can add it by default
> for people to optionally use it with `mach build faster`.

How much is the overhead?

Comment 4

[Gregory Szorc [:gps]]

0.1s on my MBP.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f878931c06c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5fa86cd2980

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f878931c06c1
https://hg.mozilla.org/mozilla-central/rev/e5fa86cd2980