1208078 - Dragging a tab in e10s windows shows an ugly tab preview/thumbnail (fully opaque, drop shadow, beveled borders)

Status: VERIFIED FIXED

Description

[Jared Wein [:jaws] (behind on reviews and bugmail) (please needinfo? me)]

STR:
Drag a tab horizontally through the tabbar and look at the tab preview.

On non-e10s windows, the preview is translucent whereas on e10s the preview is opaque and has a drop shadow with beveled borders.

Looking around, this may be related to bug 1194311?

Seen on Windows 10 with HiDPI.

Comment 1

[Tracy Walker [:tracy]]

I can reproduce on Mac.  Works fine in New non-e10s window.

Comment 2

[Neil Deakin (not available until Aug 9)]

On e10s we use a panel for the drag image rather than the OS-supplied drag feedback. We should investigate improving its appearance.

Comment 3

[Jared Wein [:jaws] (behind on reviews and bugmail) (please needinfo? me)]

I filed bug 1208084 which describes an alternate styling that we could maybe use the panel for.

Comment 4

[Neil Deakin (not available until Aug 9)]

Created attachment 8666876 [details] [diff] [review]
Improve drag panel appearance

This makes the appearance appear like non-e10s on Mac, and mostly like it on Windows. It adds transparency and removes the drop shadow. On Windows, there is a border around it which I'm looking into how to remove.

Comment 5

[Neil Deakin (not available until Aug 9)]

Jim, when I try this patch on Windows, the panel widget for the drag feedback image still has a bevelled border on it. I couldn't find any combination of the style bits or WS_EX* extended style bits that seemed to be adding it. Do you know what I'm missing here?

Comment 6

[Jim Mathies [:jimm]]

Really strange, I don't see many differences between this and our tooltip windows. The few differences i do see I removed and still ended up with the beveled edge. Are we sure that's not getting added via content?

panel:
[11F73500] CreateWindow mWindowType=2 mBorderStyle=-1 mIsTopWidgetWindow=0 style=82000000 exstyle=2000080
[11F73500] SetWindowTranslucencyInner transparent=1 style=86000000 exstyle=2080080

tooltip:
[C275400] CreateWindow mWindowType=2 mBorderStyle=-1 mIsTopWidgetWindow=1 style=82000000 exstyle=2000088
[C275400] SetWindowTranslucencyInner transparent=1 style=86000000 exstyle=2080088

- ex style difference is WS_EX_TOPMOST

the tooltip does not have a parent widget, but I removed that and it didn't change anything. I also removed the drop shadow class which didn't help.

Does the panel have a xul window+markup associated with it?

Comment 7

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #6)
> the tooltip does not have a parent widget, but I removed that and it didn't

the tooltip *doesn't* have a parent.

Comment 8

[Ciprian Muresan [:cmuresan], Desktop Engineering QA]

Hi,

I have managed to reproduce this on Windows 10, Windows 7, Ubuntu 14.04 and Mac OS X 10.7 on the latest Aurora (46.0a2) only with e10s enabled.

Build ID    20160207004019
User Agent  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:46.0) Gecko/20100101 Firefox/46.0

Thanks,
Cipri

Comment 9

[Neil Deakin (not available until Aug 9)]

Created attachment 8762077 [details] [diff] [review]
Updated patch

Still unsure about the border on Windows, but this patch improves things on all platforms, so we can further investigate later.

Comment 10

[Jared Wein [:jaws] (behind on reviews and bugmail) (please needinfo? me)]

Comment on attachment 8762077 [details] [diff] [review]
Updated patch

Review of attachment 8762077 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. I can confirm that the border appears for me on Windows too, but this feels like an improvement still.

Comment 11

[Jared Wein [:jaws] (behind on reviews and bugmail) (please needinfo? me)]

I should add that the borders may not be such a problem if bug 1208084 is fixed.

Comment 12

[Neil Deakin (not available until Aug 9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c9a0e822c0c8a009e6b96926279b8868b0e2f69
Bug 1208078, improve drag feedback appearance in e10s, r=jared

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c9a0e822c0c

Comment 14

[Chris Peterson [:cpeterson]]

Neil, should we uplift this e10s bug fix from Nightly 50 to Aurora 49 or even Beta 48? We plan to enable e10s by default for some release channel users with Firefox 48.

Comment 15

[Neil Deakin (not available until Aug 9)]

Comment on attachment 8762077 [details] [diff] [review]
Updated patch

Approval Request Comment
[Feature/regressing bug #]: None, e10s only
[User impact if declined]: minor appearance polish of the translucent drag feedback to remove border/drop shadow 
[Describe test coverage new/current, TreeHerder]: manual testing
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 16

[Chris Peterson [:cpeterson]]

wontfix for Beta 48.

Comment 17

[Liz Henry (:lizzard) (needinfo? me)]

Comment on attachment 8762077 [details] [diff] [review]
Updated patch

Fix for dragged tabs ugliness, please uplift to 49 aurora.

Comment 18

[Liz Henry (:lizzard) (needinfo? me)]

Cornel, this might be good for your team to verify on aurora once it lands.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1aa23cad1885

Comment 20

[Paul Silaghi, QA [:pauly]]

Verified fixed on 50.0a1 (2016-07-03), 49.0a2 (2016-07-04) Win 7, Ubuntu 14.04, OS X 10.12.
Found a new related issue on linux - bug 1284244