1208208 - "Options" button's switch-to-tab can switch to about:preferences page in the middle of tabs list, so current tab may get lost

Status: NEW

(Firefox :: Settings UI, defect)

Description

[arni2033]

Since all these new features were introduced in firefox, they impair the performance of more and more

All STRs in this bug are based on a model:
   open Options in 1st tab
-> open many other tabs
-> click Options button when some important tab is active
=> [result]   there's no obvious way to return to the important tab

  [EXAMPLE. There's no need to perform these steps]
1. Open google image search, e.g. https://www.google.com/search?tbm=isch&q=test
2. Right-click an image, click "Save Image As..."   [when OS dialog appears, suddenly realize that you want to set another folder for downloads. Close that dialog]
3. Click menu (≡)->Options   [about:preferences will open in a new tab. Decide that current downloads folder is actually OK, but leave preferences page open in case you want to change it]
4. Open many new tabs to cause overflow in TabsToolbar. Press Ctrl+T  10 more times
5. Open https://github.com/
6. Click magnifier in the search bar, then click «Add "GitHub"»
7. Click "Change Search Options" to set Github as default search engine [about:preferences tab from step 3 will become active. Decide that you actually don't need GitHub as default search engine, so - make no changes]
8. Press Ctrl+W to close preferences window

Result:       Some irrelevant tab becomes active tab.
Expectations: The tab which was active before about:preferences should become active.

Note:         This is actually a *regression* from firefox ~37 and shouldn't be marked as enhancement