1208217 - paste event listener doesn't fire in documents with no editor component

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

Appears (at first impression) to be due to a regression after bug 1159490 (probably related to menu item fixes).

For STR see bug 1159490 comment 10 - the problem doesn't occur when there is a contenteditable node in the page.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

(In reply to Michael Layzell [:mystor] from comment #0)
> Appears (at first impression) to be due to a regression after bug 1159490
> (probably related to menu item fixes).
> 
> For STR see bug 1159490 comment 10 - the problem doesn't occur when there is
> a contenteditable node in the page.

Back when I filed this, I checked, and this isn't a regression, but rather a feature which I meant to add in bug 1159490 and didn't.

Comment 4

[:ehsan akhgari]

Do you plan to fix this, Michael?

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable paste event listener in documents with no editor component

This patch whitelists the paste command in documents without an editor component. It appears to fix the problem.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e6b541a5663

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8752292 [details] [diff] [review]
Enable paste event listener in documents with no editor component

My review queue is long. Enn, perhaps you could take a look at this.

Comment 7

[Neil Deakin]

Comment on attachment 8752292 [details] [diff] [review]
Enable paste event listener in documents with no editor component

># HG changeset patch
># User Michael Layzell <[e-mail]>
>
>Bug 1208217 - Enable paste event listener in documents with no editor component, r=smaug
>
>diff --git a/dom/base/nsGlobalWindowCommands.cpp b/dom/base/nsGlobalWindowCommands.cpp
>index 110af14..f3b204f 100644
>--- a/dom/base/nsGlobalWindowCommands.cpp
>+++ b/dom/base/nsGlobalWindowCommands.cpp
>@@ -479,17 +479,18 @@ NS_IMPL_ISUPPORTS(nsClipboardCommand, nsIControllerCommand)
> nsresult
> nsClipboardCommand::IsCommandEnabled(const char* aCommandName, nsISupports *aContext, bool *outCmdEnabled)
...
>-      strcmp(aCommandName, "cmd_cut"))
>+      strcmp(aCommandName, "cmd_cut") &&
>+      strcmp(aCommandName, "cmd_paste"))
>     return NS_OK;
> 
>   nsCOMPtr<nsPIDOMWindowOuter> window = do_QueryInterface(aContext);
>   NS_ENSURE_TRUE(window, NS_ERROR_FAILURE);
> 
>   nsCOMPtr<nsIDocument> doc = window->GetExtantDoc();
>   if (doc->IsHTMLOrXHTML()) {
>     // In HTML and XHTML documents, we always want cut and copy commands to be enabled.

Update the comment here.

>    *outCmdEnabled = true;
>  } else {
>    // Cut isn't enabled in xul documents which use nsClipboardCommand
>    if (strcmp(aCommandName, "cmd_cut")) {
>      *outCmdEnabled = nsCopySupport::CanCopy(doc);
>    }
>  }

The else clause will need to be changed. Better if it explicitly matches only the two copy commands.
  
>   EventMessage eventMessage = eCopy;
>   if (strcmp(aCommandName, "cmd_cut") == 0) {
>     eventMessage = eCut;
>   }
>+  if (strcmp(aCommandName, "cmd_paste") == 0) {
>+    eventMessage = ePaste;
>+  }

else if

>   bool actionTaken = false;
>   nsCopySupport::FireClipboardEvent(eventMessage,
>                                     nsIClipboard::kGlobalClipboard,
>                                     presShell, nullptr, &actionTaken);
> 
>   if (!strcmp(aCommandName, "cmd_copyAndCollapseToEnd")) {
>     dom::Selection *sel =

While you're here can you update this to not do this last conditional block for cmd_copyAndCollapseToEnd when FireClipboardEvent returns true?

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable paste event listener in documents with no editor component

New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa4b2d1a01d5

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable paste event listener in documents with no editor component

Fix some test failures on try

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d91d214441

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f4d91d214441