1208410 - Remove 'Firefox Marketplace' from the list of default Top Sites thumbnails

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karen Rudnitski [:kar]]

Please remove the Marketplace thumbnail from the default Top Sites thumbnail list. 

* No replacement is currently identified and should not block
* This will stop having an in-product pointer to the Firefox Marketplace. Although fennec users are going to the Marketplace in surprisingly ok numbers, there is single digit conversion for WebApps, likely due to lack of interesting content.

Let's do this as soon as possible, although there's no specific driver.

Comment 1

[Barbara Bermes [:barbara] - NI please!]

all good and confirmed, should go into 44

Comment 2

[Allison Naaktgeboren :ally]

Attachment: removeMarketplaceTopsite

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Ally, can you point me to the code where suggested sites tiles are created? I'm not sure how your patch works because I'm missing that context.

Comment 4

[Allison Naaktgeboren :ally]

Much of it build code. We have a ranked order and the urls must not match and icons needs to be here or the build fails
mobile/locales/en-US/chrome/region.properties
mobile/android/base/resources/drawable-xhdpi/suggestedsites_*

the build processes that into JSON that we'll use in java
python/mozbuild/mozbuild/action/generate_suggestedsites.py

we do our UI thing where we convert the JSON into a blog
mobile/android/base/db/SuggestedSites.java in particular
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/db/SuggestedSites.java#472

https://reviewboard.mozilla.org/r/14633/ <- is adding stuff for kidfox's suggested sites/topsites and i think the patch that makes it most clear how the magic works

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8672052 [details] [diff] [review]
removeMarketplaceTopsite

Review of attachment 8672052 [details] [diff] [review]:
-----------------------------------------------------------------

Bugzilla says only xhdpi was deleted – could be a glitch, but make sure all dpi are deleted.

Seeing the precedent on bug 1125280 and the explanation in comment 4, wfm.

Comment 6

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/fx-team/rev/308e28cb1d94

Comment 7

[Nigel Babu [:nigelb]]

I'm reasonably confident that this has caused bustage in robocop tests that look like this:

https://treeherder.mozilla.org/logviewer.html#?job_id=5108581&repo=fx-team

 18:01:27  WARNING -  TEST-UNEXPECTED-FAIL | testDistribution | JSON tiles data matched - got [{"id":123},{"id":456},{"id":632},{"id":630},{"id":631}], expected [{"id":123},{"id":456},{"id":632},{"id":629},{"id":630},{"id":631}]
 18:01:27     INFO -  0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testDistribution | JSON tiles data matched - got [{"id":123},{"id":456},{"id":632},{"id":630},{"id":631}], expected [{"id":123},{"id":456},{"id":632},{"id":629},{"id":630},{"id":631}]
 18:01:27     INFO -  	at junit.framework.Assert.fail(Assert.java:50)
 18:01:27     INFO -  	at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:128)
 18:01:27     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:150)
 18:01:27     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.is(FennecMochitestAssert.java:156)
 18:01:27     INFO -  	at org.mozilla.gecko.tests.testDistribution.checkTilesReporting(testDistribution.java:490)
 18:01:27     INFO -  	at org.mozilla.gecko.tests.testDistribution.testDistribution(testDistribution.java:144)
 18:01:27     INFO -  	at java.lang.reflect.Method.invokeNative(Native Method)
 18:01:27     INFO -  	at java.lang.reflect.Method.invoke(Method.java:525)
 18:01:27     INFO -  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
 18:01:27     INFO -  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
 18:01:27     INFO -  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
 18:01:27     INFO -  	at org.mozilla.gecko.tests.BaseTest.runTest(BaseTest.java:132)
 18:01:27     INFO -  	at junit.framework.TestCase.runBare(TestCase.java:134)
 18:01:27     INFO -  	at junit.framework.TestResult$1.protect(TestResult.java:115)
 18:01:27     INFO -  	at junit.framework.TestResult.runProtected(TestResult.java:133)
 18:01:27     INFO -  	at junit.framework.TestResult.run(TestResult.java:118)
 18:01:27     INFO -  	at junit.framework.TestCase.run(TestCase.java:124)
 18:01:27     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
 18:01:27     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
 18:01:27     INFO -  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
 18:01:27     INFO -  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
 18:01:27  WARNING -  TEST-UNEXPECTED-FAIL | testDistribution | Exception caught - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testDistribution | JSON tiles data matched - got [{"id":123},{"id":456},{"id":632},{"id":630},{"id":631}], expected [{"id":123},{"id":456},{"id":632},{"id":629},{"id":630},{"id":631}]
 18:01:27     INFO -  TEST-PASS | testDistribution | clean up mock package - deleted /data/data/org.mozilla.fennec/mock-package.zip

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4c34f7dbc980

Comment 9

[Richard Newman [:rnewman]]

Bustage fix:

https://hg.mozilla.org/integration/fx-team/rev/4c34f7dbc980

I added a note to region.properties to update the test when changing suggested sites.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/308e28cb1d94

hey Allision, this landed with the wrong bug number, could you make sure this checkins have the correct bug number :) Thanks :)

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/3993171f4422

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c34f7dbc980

Comment 13

[Flaviu Cos]

Verified as fixed in build 44.0.1 2015-10-18;
Device Asus Transformer Pad (Android 4.2.1).