1208560 - Unship service workers and push notifications in Firefox 42

Status: VERIFIED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

Since we aren't shipping push in 42, there is no reason to support service workers.

Comment 1

[(no longer active)]

Attachment: Unship service workers in Firefox 42

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8666110 [details] [diff] [review]
Unship service workers in Firefox 42

Review of attachment 8666110 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1949,2 @@
>  // Enable Push API.
>  pref("dom.push.enabled", true);

Also this this in that case, since without serviceworkers, push is useless.

Comment 3

[Jean-Yves Perrier [:teoli]]

Dev-doc-needed to update MDN's compat tables.

Comment 4

[(no longer active)]

Comment on attachment 8666110 [details] [diff] [review]
Unship service workers in Firefox 42

Approval Request Comment
Service workers and push will not ship on 42.  This patch disables them.

Note that this will only land on beta.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8666110 [details] [diff] [review]
Unship service workers in Firefox 42

ok, let's disable it.

Ehsan, we had "Ship Push messaging with disabled web notifications from ServiceWorkers" in the release notes, I guess we should remove it, right?

Comment 6

[(no longer active)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #5)
> Ehsan, we had "Ship Push messaging with disabled web notifications from
> ServiceWorkers" in the release notes, I guess we should remove it, right?

Yes please.  I'm setting the relnote flag as a reminder.

Comment 7

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b0bb745a61a

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Removed from the 42 beta release notes!

Comment 9

[Jean-Yves Perrier [:teoli]]

If I understand well here, this means that SW and Push API will be enable by default in Fx 43 (unless the same patch that has been applied here to Fx 42 Beta is applied to Fx 43 when it will reach beta)

[If this happens, will it happens here or in another bug?]

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Exactly.

If this happens again, it might be in this bug or in a new bug (sorry about that).
We will try to update this bug if this happens in another bug.

Comment 11

[Arthur Stolyar [:nekr]]

What is the the problem in having SW without push nofications? SW is useful even without it.

Comment 12

[(no longer active)]

(In reply to Arthur Stolyar [:nekr] from comment #11)
> What is the the problem in having SW without push nofications? SW is useful
> even without it.

Our service worker implementation can only deal with fetch and push events, neither of which are available in 42.  Without those two, service workers are useless.

Comment 13

[Edwin Wong [:edwong]]

I've verified this bug landed in Fx42b4

Comment 15

[Alice Wyman]

(In reply to Jean-Yves Perrier [:teoli] from comment #9)
> If I understand well here, this means that SW and Push API will be enable by
> default in Fx 43 (unless the same patch that has been applied here to Fx 42
> Beta is applied to Fx 43 when it will reach beta)
> 
> [If this happens, will it happens here or in another bug?]

See bug 1215230

Comment 16

[Chris Mills [:cmills]]

Again, see bug 1215230 for updates on SW compat info.