1208669 - Duplicate contact screen has a status bar color that does not match header

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Status bar color

Description:
When the user is on the duplicate contact screen the status bar color is black which does not match the color of the header.

Repro Steps:
1) Update a Aries to 20150925134904
2) Create a contact
3) Create another contact with the same number
4) Observe status bar

Actual:
the status bar color is not consistent with the header

Expected:
It is expected that the status bar color matches the header or the previous app

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150925134904
Gaia: 5a0a1bb1a863b07528ebc1a04652ed656d8333b3
Gecko: 543e1b3a25887258a70d1f2dab3cb287d0d500e4
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: Screenshot, logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150925103004
Gaia: 5a0a1bb1a863b07528ebc1a04652ed656d8333b3
Gecko: 5abe3c4deab94270440422c850bbeaf512b1f38d
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
The status bar color is black
------------------------------------
This issue DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 [Full Flash]
BuildID: 20150923003003
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: 65ddad73ad6b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The status bar color matches the previous screen

Comment 3

[Max Murrell [MMurrell]]

B2G Inbound Regression Window:

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150728071744
Gaia: ba33139c251108308cf882c152d9a7fff001bb83
Gecko: 7a4c3baef26d
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 42.0a1 (2.5) 
Firmware Version: v18D

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150728120244
Gaia: 862f0895f3f5a97200601542d99a152a46385a0b
Gecko: 833403badc41
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 42.0a1 (2.5) 
Firmware Version: v18D

Last Working gaia / First Broken gecko - Issue does not occur 
Gaia: ba33139c251108308cf882c152d9a7fff001bb83
Gecko: 833403badc41

First Broken gaia / Last Working gecko - Issue does occur
Gaia: 862f0895f3f5a97200601542d99a152a46385a0b
Gecko: 7a4c3baef26d

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/ba33139c251108308cf882c152d9a7fff001bb83...862f0895f3f5a97200601542d99a152a46385a0b

This issue is caused by changes made in Bug 1182509

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Jorge this issues seems to have been caused by the changes for bug 1182509.  Can you please take a look?

Comment 5

[Maria Angeles Oteo (:oteo)]

Manu, can you have a look at this bug, please?

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] mancas:bug1208669 > mozilla-b2g:nga

Comment 7

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8668420 [details] [review]
[gaia] mancas:bug1208669 > mozilla-b2g:nga

The main issue here is caused by the popup window created by the system when the app uses |window.open|. It is because of a css rule that set the background color of the status bar. I'm not sure if this patch will broke anything else so feel free to ping anyone who have more idea about the status bar theme.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8668420 [details] [review]
[gaia] mancas:bug1208669 > mozilla-b2g:nga

This must be reviewed by a system peer.

Alberto are you ok with this review? Or can you redirect to the correct peer?

Thanks!

Comment 9

[Alberto Pastor [:albertopq]]

I'm not sure what the spec was for window.open statusbar color. Etienne, any idea?

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Alberto Pastor [:albertopq] from comment #9)
> I'm not sure what the spec was for window.open statusbar color. Etienne, any
> idea?

Don't think we have one.
My best guest would be to honor the meta if there is one, or default to black.

That said I don't understand the patch since, is contacts using the GlobalOverlayWindow?

Comment 11

[Alberto Pastor [:albertopq]]

It just works because it makes the selector more specific. Without that, is using this selector:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/window.css#L10

I'm not sure what the .render class is meant to do. If the fact that .render is added or not to the window is what makes the difference for using black or transparent, I think the patch is acceptable.

Comment 12

[Etienne Segonzac (:etienne)]

(In reply to Alberto Pastor [:albertopq] from comment #11)
> It just works because it makes the selector more specific. Without that, is
> using this selector:
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/window.
> css#L10
> 
> I'm not sure what the .render class is meant to do. If the fact that .render
> is added or not to the window is what makes the difference for using black
> or transparent, I think the patch is acceptable.

Well adding specificity to a rule that is already using |!important| is probably a sign that several things are not acceptable :) (none of which are yours or Manuel's fault).

So we should at least file a follow up and add a comment referencing it.

Comment 13

[Alberto Pastor [:albertopq]]

Well, is the background-color the one that affects here, but I agree, we should fix it properly. I'm fine with landing this (taking into account that the selector without the '.render' class is as good/bad as this one), but only if we create a new bug for fixing it and add a comment pointing to it.

Comment 14

[Alberto Pastor [:albertopq]]

Comment on attachment 8668420 [details] [review]
[gaia] mancas:bug1208669 > mozilla-b2g:nga

Clearing

Comment 15

[BMO Automation]

Firefox OS is not being worked on