1182509 - [Contacts][NGA] Open contacts_matching with window.open

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jorge Prudencio [:jorgep]]

In orden to obtain a more webby behavior and reduce problems with history, we are going to load contacts_matching tool with window.open instead of an iframe.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jpruden92:bug_iframe-vs-wopen > mozilla-b2g:master

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8635975 [details] [review]
[gaia] jpruden92:bug_iframe-vs-wopen > mozilla-b2g:master

Great job Jorge! Some comments to address and one test, and we are ready to review this! :)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8635975 [details] [review]
[gaia] jpruden92:bug_iframe-vs-wopen > mozilla-b2g:master

Left some comments on gh, but overall is looking pretty good.

Could not see the title changing, just saw the url instead of the window title. I saw we have code for changing the window title, perhaps we should talk with a wm peer to check if that works.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Once we land this bug, we should check if bug 1177357 is still happening

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:window_open > mozilla-b2g:master

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Excellent work.