1208705 - Theme: Set accentColor on Android 5.0+

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently we do not set an accentColor (for theming UI controls) in our theme. That's why checkboxes and headers have this cyan color in settings (See screenshot).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: device-2015-09-26-100053.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

@Anthony: What's the best color to use here?

Comment 3

[Shubham Jain]

hello
I'm here for my first bug. Can you please help me through resolving bugs in firefox?

Comment 4

[Shubham Jain]

Attachment: accent set to @color/fennec_ui_orange

Comment 5

[Shubham Jain]

Any input from Anthony so far ?

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey Shubham!

I've been thinking about this more. 

It seems like the best color here would be our Action Orange (#E66000) which is what seems to be there.

Comment 7

[Shubham Jain]

Attachment: color_patch.diff

Set the accent color to action_orange. @aAnthony I actually made the same choice. In fact the screenshot named color/fennec_orange that i attached is actually action_orange. i had accidentally named it incorrectly.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8666860 [details] [diff] [review]
color_patch.diff

Review of attachment 8666860 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. This is looking good!

The commit message is a bit misleading. This color does not relate to menus. It's used to tint UI controls in general (Android 5+). Maybe change it to something like: "Set colorAccent in v21+ theme.". And you can add the reviewer at the end of the message. So in this case the commit message could read something like this:

"Bug 1208705 - Set colorAccent in v21+ theme. r=sebastian"

Feel free to upload an updated patch. This does not require a new review.

I'll push the patch to try[1] for you. If all tests pass then you can add the "checkin-needed" [2] keyword to this bug in order to get your changes commited and pushed.

[1] https://wiki.mozilla.org/Build:TryServer 
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 9

[Shubham Jain]

cool, Thank you! 
I'll upload an updated patch shortly.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49c1f5c97112

Comment 11

[Shubham Jain]

Attachment: accent_patch_updated.diff

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6720d34c74b4

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6720d34c74b4