Closed Bug 1208705 Opened 4 years ago Closed 4 years ago
Theme: Set accent
Color on Android 5 .0+
Currently we do not set an accentColor (for theming UI controls) in our theme. That's why checkboxes and headers have this cyan color in settings (See screenshot).
@Anthony: What's the best color to use here?
Whiteboard: [lang=xml][good first bug]
hello I'm here for my first bug. Can you please help me through resolving bugs in firefox?
Assignee: nobody → shubhamkjain
Any input from Anthony so far ?
Hey Shubham! I've been thinking about this more. It seems like the best color here would be our Action Orange (#E66000) which is what seems to be there.
Flags: needinfo?(alam) → needinfo?(shubhamjindal18)
Flags: needinfo?(shubhamjindal18) → needinfo?(shubhamkjain)
Set the accent color to action_orange. @aAnthony I actually made the same choice. In fact the screenshot named color/fennec_orange that i attached is actually action_orange. i had accidentally named it incorrectly.
Comment on attachment 8666860 [details] [diff] [review] color_patch.diff Review of attachment 8666860 [details] [diff] [review]: ----------------------------------------------------------------- Nice. This is looking good! The commit message is a bit misleading. This color does not relate to menus. It's used to tint UI controls in general (Android 5+). Maybe change it to something like: "Set colorAccent in v21+ theme.". And you can add the reviewer at the end of the message. So in this case the commit message could read something like this: "Bug 1208705 - Set colorAccent in v21+ theme. r=sebastian" Feel free to upload an updated patch. This does not require a new review. I'll push the patch to try for you. If all tests pass then you can add the "checkin-needed"  keyword to this bug in order to get your changes commited and pushed.  https://wiki.mozilla.org/Build:TryServer  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8666860 - Flags: review?(s.kaspari) → review+
cool, Thank you! I'll upload an updated patch shortly.
Attachment #8667202 - Flags: review+
You need to log in before you can comment on or make changes to this bug.