Use the MenuText color for the tab audio indicator in the tab bar too

RESOLVED WORKSFORME

Status

()

Firefox
Theme
RESOLVED WORKSFORME
2 years ago
a year ago

People

(Reporter: Ehsan, Assigned: rakhisharma, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Similar to bug 1207565 but for the icons in the tab bar.

Comment 1

2 years ago
The same for light developer edition theme. I hope this case will be covered by this bug.
> screenshot:   https://dl.dropboxusercontent.com/s/4geg3jcl1dew91p/bug%201208760%20comment%201.png
(Assignee)

Comment 2

2 years ago
Hey,I have started working on this bug, will you please assign this to me :)

Updated

2 years ago
Assignee: nobody → Rakhish1994
Mentor: gijskruitbosch+bugs@gmail.com

Comment 3

2 years ago
Ehsan, can you add more details about in which circumstances (besides the light devedition theme noted in comment #1 ) the icon should be inverted where it isn't currently? I'd ask Dão but I believe he's on PTO right now.
Flags: needinfo?(ehsan)
(Reporter)

Comment 4

2 years ago
I'm not 100% sure to be honest.  I filed this bug since Dao asked me to, but I'm afraid I can't speak for him as to what problems he wanted to see fixed here.  Redirecting to him.
Flags: needinfo?(ehsan) → needinfo?(dao)
(Assignee)

Comment 5

2 years ago
Created attachment 8753795 [details]
MozReview Request: Bug 1208760 - Use the MenuText color for the tab audio indicator in the tab bar too. r= Gijs.

Review commit: https://reviewboard.mozilla.org/r/53486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53486/
(Assignee)

Comment 6

2 years ago
Hi, If this bug is only about the color of icon in the tab bar (sound indicator should be white), then I think bug 1268498 resolve this issue. If there is anything else needs to be done here, please let me know.
Thanks :)
fixed by bug 1268498 and bug 1295947
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(dao+bmo)
Resolution: --- → WORKSFORME

Updated

a year ago
See Also: → bug 1327400
You need to log in before you can comment on or make changes to this bug.