Closed
Bug 1208782
Opened 10 years ago
Closed 10 years ago
Autophone - do not attempt to get response json during Treeherder submission error if response is None
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox44 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.99 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
In https://github.com/mozilla/autophone/blob/master/autophonetreeherder.py#L93, if the response retrieved from the exception is None, an AttributeError will be thrown when attempting to get the json from the response which results in killing the worker.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bob
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8667418 -
Flags: review?(jmaher)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8667418 [details] [diff] [review]
bug-1208782-handle-null-response-from-treeherder-v1.patch
Review of attachment 8667418 [details] [diff] [review]:
-----------------------------------------------------------------
oh, this is simple and good!
Attachment #8667418 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•