1208789 - Unreachable code after return in browser_documentnavigation.js

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Matthew N. [:MattN]]

There is dead code after a return at http://hg.mozilla.org/mozilla-central/annotate/6457f01e4bcb/browser/base/content/test/general/browser_documentnavigation.js#l108 which causes a warning.

108   return ContentTask.spawn(gBrowser.selectedBrowser, { }, function* () {
109     return content.document.getElementById("button1").focus();
110   });
111 
112   yield* expectFocusOnF6(false, "main-window", gURLBar.inputField,
113                                 false, "basic focus content page with button focused urlbar");
…

Comment 1

[Neil Deakin]

Attachment: browser_documentnavigation_fix

Turns out this was masking an actual bug, that can be reproduced as follows:

1. Load a page and tab to it such that the document is focused (focus ring on document)
2. Click the urlbar to focus it
3. Press Shift+F6

Actual: Nothing appears to happen.
Expected: The document is focused again.

Comment 2

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8305fc7ffd1c2adc305f9047276dd2c1aed3c1c5
Bug 1208789, clear starting node before traversing backwards by document, r=smaug

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8305fc7ffd1c