1208870 - [cs] Firefox for Android: review list of shipping searchplugins

Status: RESOLVED FIXED

(Mozilla Localizations :: cs / Czech, defect)

Comment 3

[Francesco Lodolo [:flod]]

One per bug for each product is a lot easier to manage.

To summarize:
* Add DuckDuckGo
* Add Mapy.cz
* Replace Zbozi.cz with Heureka.cz (e-commerce)

Comment 4

[Francesco Lodolo [:flod]]

For reference:
* heureka.cz: bug 590522
* mapy.cz: bug 958531

To add these searchplugins to Firefox for Android it will be necessary to reach out to them for the new icon format: square 96x96 px transparent PNG, rounded corners with 6px radius, colored background for the main image.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Asked Heuréka for the new icon. Mapy.cz icon already obtained during bug 1193192.

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Favicon_a_png.zip

Heureka.cz icons just arrived. :)

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: bug1208870.patch

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8707900 [details] [diff] [review]
bug1208870.patch

Review of attachment 8707900 [details] [diff] [review]:
-----------------------------------------------------------------

Tested both searchplugins and they work fine. The only real issue is DDG.

One more nit: put the searchplugins in list.txt in alphabetical order.

::: mobile/searchplugins/heureka-cz.xml
@@ +3,5 @@
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Heuréka</ShortName>
> +<Description>Vyhledávání na Heuréka.cz</Description>

You can drop the description on mobile.

::: mobile/searchplugins/list.txt
@@ +1,3 @@
>  google
>  seznam-cz
> +duckduckgo-cz

Please use the 'centralized' duckduckgo (from en-US), only adding it to list.txt.

I know some region specific parameters are lost, but we don't want to create regional variants and risk to lose useful updates.

::: mobile/searchplugins/mapy-cz.xml
@@ +3,5 @@
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Mapy.cz</ShortName>
> +<Description>Vyhledávání na Mapy.cz</Description>

Same here, you can drop the description.

Comment 9

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: bug1208870.patch (v2)

Thank you. Updated.

Btw. en-US list.txt is not sorted alphabetically https://hg.mozilla.org/releases/mozilla-aurora/file/tip/mobile/locales/en-US/searchplugins/list.txt.

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 8707958 [details] [diff] [review]
bug1208870.patch (v2)

Review of attachment 8707958 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a507a5b245d1

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ] from comment #11)
> https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a507a5b245d1

Note for future landings: after receiving the review, update the commit message before landing with r=REVIEWER_NAME.

In this case: "Bug 1208870 - [cs] Firefox for Android: review list of shipping searchplugins, r=flod". That makes it clear who reviewed the patch without going into the bug.

Comment 13

[Francesco Lodolo [:flod]]

Got an email this morning from my automated system and realized I missed a piece in review: we removed zbozi-cz.xml from list.txt but not the actual .xml file.

Pushed a follow-up
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/f818967d1358
https://hg.mozilla.org/l10n-central/cs/rev/f818967d1358

Comment 14

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you for both.

My mistake in the patch v2.