Replace searchplugin for Jyxo.cz with Mapy.cz

RESOLVED FIXED

Status

Mozilla Localizations
cs / Czech
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: JasnaPaka, Assigned: JasnaPaka)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Split from Bug 597988.

Firefox in czech version contains search plugin for Jyxo.cz. Jyxo.cz was czech search engine which was closed a few months/years ago. So at this moment we have inactive searchplugin in Firefox.

We would like to replace this modul with Mapy.cz (http://www.mapy.cz/). Mapy.cz is popular map service in Czech republic (something like Google Maps) and this service is developed by Seznam.cz (http://www.seznam.cz/)
(Assignee)

Comment 1

4 years ago
Created attachment 8358408 [details] [diff] [review]
Patch v1

Remove searchplugin for Jyxo.cz and add Mapy.cz (Firefox for Desktop and Firefox for Metro).
Attachment #8358408 - Flags: review?(francesco.lodolo)
Ok, I tried to read the discussion in bug 597988.

Current list of searchplugins.

google (generic)
heureka-cz (e-commerce)
jyxo-cz (inactive)
seznam-cz (generic)
slunecnice-cz (e-commerce?)
wikipedia-cz

mapy.cz is a map search service, so I don't see any risk of overpopulating one category.

@Joanne
In bug 597988 comment 32 you wrote there's a commercial relationship with Seznam. Do we need specific tracking parameters for this searchplugin? In the current proposed patch there's a sourceid="firefox" like in other Seznam's searchplugins.
Flags: needinfo?(jnagel)

Comment 3

4 years ago
Sorry for the delay, I was doing some research and needed to confirm with Bryan (Clark).  It makes sense to include mapy.cz and I have reached out to my contact at Seznam for help obtaining approval and information on the necessary parameters for search requests.

I'll follow as soon as I have a response.  Thanks, Joanne
Flags: needinfo?(jnagel)

Comment 4

4 years ago
Hi,  I've received approval from Seznam to include mapy.cz and they suggest we look at the search module in the mapy.cz add-on in AMO:  https://addons.mozilla.org/cs/firefox/addon/mapycz/?src=search

If that does not resolve your questions, please let me know the specific ask and I'll reach back out to them.  Thanks, Joanne
Created attachment 8361814 [details]
Reference searchplugin from AMO

Thanks Joanne, I think we should have all the information we need.
Comment on attachment 8358408 [details] [diff] [review]
Patch v1

Review of attachment 8358408 [details] [diff] [review]:
-----------------------------------------------------------------

Once we fixed these details we should be ready to go.

::: browser/searchplugins/mapy-cz.xml
@@ +5,5 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Mapy.cz</ShortName>
> +<Description>Vyhledávání na Mapy.cz</Description>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/x-icon;base64,AAABAAEAEBAAAAEAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAQAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7M4AAOwbAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADsKgAAAAAAAAAAAAAAAAAAAAAAAOz/AADssgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADsaAAA7NMAAOw6AAAAAAAAAAAAAAAAAADsegAA7P8AAOwSAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7P8AAOz/AADsnQAAAAAAAAAAAAAAAAAAAAAAAOz/AADsvwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7JMAAAAAAAAAAAAAAAAAAAAAAADs/wAA7P8AAAAAAAAAAAAAAAAAAOxBAAAAAAAAAAAAAOwsAADs/wAA7P4AAOyQAAAAAAAAAAAAAAAAAAAAAAAA7K0AAOz/AADsUgAAAAAAAOxUAADs/wAA7MUAAAAAAADsTQAA7P8AAOz/AADsmQAAAAAAAAAAAAAAAAAAAAAAAOx3AADs/wAA7L8AAAAAAADsNwAA7P8AAOz/AADsDQAA7FEAAOz/AADs/wAA7JoAAAAAAAAAAAAAAAAAAAAAAADsNwAA7P8AAOz2AAAAAAAA7DAAAOz/AADs/wAA7P8AAOy+AADs/wAA7P8AAOykAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7BsAAOzOAADspgAA7DwAAOz/AADs/wAA7P8AAOz/AADssgAAAAAAAAAAAAAAAAAAAAAAAAAAAADs3gAA7P8AAOz1AADs/wAAAAcAAAAAAADsdQAA7P8AAOz/AADs/wAA7MEAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7MgAAOz/AADs/wAA7NQAAAAAAAAAAAAAAAAAAOzmAADs/wAA7P8AAOzwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOzAAADs/wAA7P8AAOx1AAAAAAAAAAAAAAAAAADsdwAA7P8AAOz/AADs/wAAAAAAAAAAAAAAAAAAAAAAAAAAAADs/wAA7P8AAOz/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7LUAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7EUAAOxIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADs4gAA7EcAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA//8AAJ/3AACf4wAAj+MAAM/jAADOwwAAxEMAAMQDAADEAwAA4AMAAOGDAADhwwAA4cMAAOPjAADn5wAA//8AAA==</Image>

Please use the data URI from the attached xml file (image quality is better)

@@ +8,5 @@
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/x-icon;base64,AAABAAEAEBAAAAEAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAQAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7M4AAOwbAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADsKgAAAAAAAAAAAAAAAAAAAAAAAOz/AADssgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADsaAAA7NMAAOw6AAAAAAAAAAAAAAAAAADsegAA7P8AAOwSAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7P8AAOz/AADsnQAAAAAAAAAAAAAAAAAAAAAAAOz/AADsvwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7JMAAAAAAAAAAAAAAAAAAAAAAADs/wAA7P8AAAAAAAAAAAAAAAAAAOxBAAAAAAAAAAAAAOwsAADs/wAA7P4AAOyQAAAAAAAAAAAAAAAAAAAAAAAA7K0AAOz/AADsUgAAAAAAAOxUAADs/wAA7MUAAAAAAADsTQAA7P8AAOz/AADsmQAAAAAAAAAAAAAAAAAAAAAAAOx3AADs/wAA7L8AAAAAAADsNwAA7P8AAOz/AADsDQAA7FEAAOz/AADs/wAA7JoAAAAAAAAAAAAAAAAAAAAAAADsNwAA7P8AAOz2AAAAAAAA7DAAAOz/AADs/wAA7P8AAOy+AADs/wAA7P8AAOykAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7BsAAOzOAADspgAA7DwAAOz/AADs/wAA7P8AAOz/AADssgAAAAAAAAAAAAAAAAAAAAAAAAAAAADs3gAA7P8AAOz1AADs/wAAAAcAAAAAAADsdQAA7P8AAOz/AADs/wAA7MEAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7MgAAOz/AADs/wAA7NQAAAAAAAAAAAAAAAAAAOzmAADs/wAA7P8AAOzwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOzAAADs/wAA7P8AAOx1AAAAAAAAAAAAAAAAAADsdwAA7P8AAOz/AADs/wAAAAAAAAAAAAAAAAAAAAAAAAAAAADs/wAA7P8AAOz/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAOz/AADs/wAA7LUAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7EUAAOxIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADs4gAA7EcAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA//8AAJ/3AACf4wAAj+MAAM/jAADOwwAAxEMAAMQDAADEAwAA4AMAAOGDAADhwwAA4cMAAOPjAADn5wAA//8AAA==</Image>
> +<Url type="text/html" method="GET" template="http://www.mapy.cz/">
> +	<Param name="query" value="{searchTerms}"/>
> +	<Param name="sourceid" value="firefox"/>

Based on Joanne's comment, let's use sourceid="Searchmodule_3" as the searchplugin in AMO.

@@ +10,5 @@
> +<Url type="text/html" method="GET" template="http://www.mapy.cz/">
> +	<Param name="query" value="{searchTerms}"/>
> +	<Param name="sourceid" value="firefox"/>
> +</Url>
> +<SearchForm>http://mapy.cz/</SearchForm>

Please use http://www.mapy.cz/
Attachment #8358408 - Flags: review?(francesco.lodolo) → review-
(Assignee)

Comment 7

4 years ago
Created attachment 8362567 [details] [diff] [review]
Patch v2

Updated patch.
Attachment #8358408 - Attachment is obsolete: true
Attachment #8362567 - Flags: review?(francesco.lodolo)
Comment on attachment 8362567 [details] [diff] [review]
Patch v2

Review of attachment 8362567 [details] [diff] [review]:
-----------------------------------------------------------------

Tested, looks good. As usual commit with a reference to bug and review and verify the bug after landing.
I'd say land this on mozilla-aurora and l10n-central.
Attachment #8362567 - Flags: review?(francesco.lodolo) → review+
(Assignee)

Comment 9

4 years ago
Thanks for review!

http://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/e7272b2fec2d
http://hg.mozilla.org/l10n-central/cs/rev/f0143a6e6dbb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.