Closed
Bug 1208922
Opened 7 years ago
Closed 7 years ago
Remove MediaDecoder::GetCDMProxy
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(6 files)
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
40 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bdf5030a0b9
Assignee | ||
Comment 2•7 years ago
|
||
Bug 1208922. Part 1 - add MediaDecoder::RequestCDMProxy() which resolves when a CDMProxy is set and capabilities are known. The client code won't need to handle the situation where a CDMProxy is set but capabilities are still unknown. This simplifies the client code a lot.
Attachment #8666549 -
Flags: review?(cpearce)
Assignee | ||
Comment 3•7 years ago
|
||
Bug 1208922. Part 2 - add MediaDecoderReader::SetCDMProxy so it won't need to ask MediaDecoder for a CDMProxy.
Attachment #8666550 -
Flags: review?(cpearce)
Assignee | ||
Comment 4•7 years ago
|
||
Bug 1208922. Part 3 - forward the CDMProxy from MediaDecoder to MediaDecoderReader via MDSM.
Attachment #8666551 -
Flags: review?(cpearce)
Assignee | ||
Comment 5•7 years ago
|
||
Bug 1208922. Part 4 - remove AbstractMediaDecoder::GetCDMProxy() and devirtualize MediaDecoder::SetCDMProxy().
Attachment #8666552 -
Flags: review?(cpearce)
Assignee | ||
Comment 6•7 years ago
|
||
Bug 1208922. Part 5 - MDSM can now query capabilities from CDMProxy without reader setting them in MediaInfo.
Attachment #8666553 -
Flags: review?(cpearce)
Assignee | ||
Comment 7•7 years ago
|
||
Bug 1208922. Part 6 - IsWaitingOnCDMResource() is not used by MDSM anymore. Remove it from MediaDecoderReader and make it private in MediaFormatReader.
Attachment #8666554 -
Flags: review?(cpearce)
Comment 8•7 years ago
|
||
Comment on attachment 8666549 [details] MozReview Request: Bug 1208922. Part 1 - add MediaDecoder::RequestCDMProxy() which resolves when a CDMProxy is set and capabilities are known. The client code won't need to handle the situation where a CDMProxy is set but capabilities are still unknown. T https://reviewboard.mozilla.org/r/20553/#review18635
Attachment #8666549 -
Flags: review?(cpearce) → review+
Comment 9•7 years ago
|
||
Comment on attachment 8666550 [details] MozReview Request: Bug 1208922. Part 2 - add MediaDecoderReader::SetCDMProxy so it won't need to ask MediaDecoder for a CDMProxy. https://reviewboard.mozilla.org/r/20555/#review18637
Attachment #8666550 -
Flags: review?(cpearce) → review+
Comment 10•7 years ago
|
||
Comment on attachment 8666551 [details] MozReview Request: Bug 1208922. Part 3 - forward the CDMProxy from MediaDecoder to MediaDecoderReader via MDSM. https://reviewboard.mozilla.org/r/20557/#review18639
Attachment #8666551 -
Flags: review?(cpearce) → review+
Comment 11•7 years ago
|
||
Comment on attachment 8666552 [details] MozReview Request: Bug 1208922. Part 4 - remove AbstractMediaDecoder::GetCDMProxy() and devirtualize MediaDecoder::SetCDMProxy(). https://reviewboard.mozilla.org/r/20559/#review18641
Attachment #8666552 -
Flags: review?(cpearce) → review+
Comment 12•7 years ago
|
||
Comment on attachment 8666553 [details] MozReview Request: Bug 1208922. Part 5 - MDSM can now query capabilities from CDMProxy without reader setting them in MediaInfo. https://reviewboard.mozilla.org/r/20561/#review18643
Attachment #8666553 -
Flags: review?(cpearce) → review+
Updated•7 years ago
|
Attachment #8666554 -
Flags: review?(cpearce) → review+
Comment 13•7 years ago
|
||
Comment on attachment 8666554 [details] MozReview Request: Bug 1208922. Part 6 - IsWaitingOnCDMResource() is not used by MDSM anymore. Remove it from MediaDecoderReader and make it private in MediaFormatReader. https://reviewboard.mozilla.org/r/20563/#review18645
Assignee | ||
Comment 14•7 years ago
|
||
Thanks for the review!
Comment 15•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/960ffcf50053 https://hg.mozilla.org/integration/mozilla-inbound/rev/f589a524b7a5 https://hg.mozilla.org/integration/mozilla-inbound/rev/db7c6afb4cb7 https://hg.mozilla.org/integration/mozilla-inbound/rev/20b1d715338b https://hg.mozilla.org/integration/mozilla-inbound/rev/f946f0d4e017 https://hg.mozilla.org/integration/mozilla-inbound/rev/1abba55f3790
Comment 16•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/960ffcf50053 https://hg.mozilla.org/mozilla-central/rev/f589a524b7a5 https://hg.mozilla.org/mozilla-central/rev/db7c6afb4cb7 https://hg.mozilla.org/mozilla-central/rev/20b1d715338b https://hg.mozilla.org/mozilla-central/rev/f946f0d4e017 https://hg.mozilla.org/mozilla-central/rev/1abba55f3790
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 18•7 years ago
|
||
\o/
You need to log in
before you can comment on or make changes to this bug.
Description
•