1208922 - Remove MediaDecoder::GetCDMProxy

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bdf5030a0b9

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 1 - add MediaDecoder::RequestCDMProxy() which resolves when a CDMProxy is set and capabilities are known. The client code won't need to handle the situation where a CDMProxy is set but capabilities are still unknown. T

Bug 1208922. Part 1 - add MediaDecoder::RequestCDMProxy() which resolves when a CDMProxy is set and capabilities are known. The client code won't need to handle the situation where a CDMProxy is set but capabilities are still unknown. This simplifies the client code a lot.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 2 - add MediaDecoderReader::SetCDMProxy so it won't need to ask MediaDecoder for a CDMProxy.

Bug 1208922. Part 2 - add MediaDecoderReader::SetCDMProxy so it won't need to ask MediaDecoder for a CDMProxy.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 3 - forward the CDMProxy from MediaDecoder to MediaDecoderReader via MDSM.

Bug 1208922. Part 3 - forward the CDMProxy from MediaDecoder to MediaDecoderReader via MDSM.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 4 - remove AbstractMediaDecoder::GetCDMProxy() and devirtualize MediaDecoder::SetCDMProxy().

Bug 1208922. Part 4 - remove AbstractMediaDecoder::GetCDMProxy() and devirtualize MediaDecoder::SetCDMProxy().

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 5 - MDSM can now query capabilities from CDMProxy without reader setting them in MediaInfo.

Bug 1208922. Part 5 - MDSM can now query capabilities from CDMProxy without reader setting them in MediaInfo.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1208922. Part 6 - IsWaitingOnCDMResource() is not used by MDSM anymore. Remove it from MediaDecoderReader and make it private in MediaFormatReader.

Bug 1208922. Part 6 - IsWaitingOnCDMResource() is not used by MDSM anymore. Remove it from MediaDecoderReader and make it private in MediaFormatReader.

Comment 8

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666549 [details]
MozReview Request: Bug 1208922. Part 1 - add MediaDecoder::RequestCDMProxy() which resolves when a CDMProxy is set and capabilities are known. The client code won't need to handle the situation where a CDMProxy is set but capabilities are still unknown. T

https://reviewboard.mozilla.org/r/20553/#review18635

Comment 9

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666550 [details]
MozReview Request: Bug 1208922. Part 2 - add MediaDecoderReader::SetCDMProxy so it won't need to ask MediaDecoder for a CDMProxy.

https://reviewboard.mozilla.org/r/20555/#review18637

Comment 10

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666551 [details]
MozReview Request: Bug 1208922. Part 3 - forward the CDMProxy from MediaDecoder to MediaDecoderReader via MDSM.

https://reviewboard.mozilla.org/r/20557/#review18639

Comment 11

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666552 [details]
MozReview Request: Bug 1208922. Part 4 - remove AbstractMediaDecoder::GetCDMProxy() and devirtualize MediaDecoder::SetCDMProxy().

https://reviewboard.mozilla.org/r/20559/#review18641

Comment 12

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666553 [details]
MozReview Request: Bug 1208922. Part 5 - MDSM can now query capabilities from CDMProxy without reader setting them in MediaInfo.

https://reviewboard.mozilla.org/r/20561/#review18643

Comment 13

[Chris Pearce [:cpearce (GMT+13)]]

Comment on attachment 8666554 [details]
MozReview Request: Bug 1208922. Part 6 - IsWaitingOnCDMResource() is not used by MDSM anymore. Remove it from MediaDecoderReader and make it private in MediaFormatReader.

https://reviewboard.mozilla.org/r/20563/#review18645

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/960ffcf50053
https://hg.mozilla.org/integration/mozilla-inbound/rev/f589a524b7a5
https://hg.mozilla.org/integration/mozilla-inbound/rev/db7c6afb4cb7
https://hg.mozilla.org/integration/mozilla-inbound/rev/20b1d715338b
https://hg.mozilla.org/integration/mozilla-inbound/rev/f946f0d4e017
https://hg.mozilla.org/integration/mozilla-inbound/rev/1abba55f3790

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/960ffcf50053
https://hg.mozilla.org/mozilla-central/rev/f589a524b7a5
https://hg.mozilla.org/mozilla-central/rev/db7c6afb4cb7
https://hg.mozilla.org/mozilla-central/rev/20b1d715338b
https://hg.mozilla.org/mozilla-central/rev/f946f0d4e017
https://hg.mozilla.org/mozilla-central/rev/1abba55f3790

Comment 18

[Bobby Holley (:bholley)]

\o/