1179498 - Make all of MediaDecoder run on the main thread

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bobby Holley (:bholley)]

There's a mostly-trivial long-tail of methods on MediaDecoder that run on other threads. Everything on MediaDecoder needs to run on the main thread.

Here's a quick list of what remains to be fixed:

QueueMetadata
IsExpectingMoreData
IsSameOriginMedia
GetStatistics
ComputePlaybackRate
SetMediaSeekable/IsTransportSeekable/IsMediaSeekable
{Start,Stop}ProgressUpdates
UpdatePlaybackOffset
GetImageContainer/InvalidateWithFlags/Invalidate
IsShutdown
CanPlayThrough
GetCDMProxy

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Here's a quick list of what remains to be fixed:

GetStatistics
ComputePlaybackRate
SetMediaSeekable/IsTransportSeekable/IsMediaSeekable
UpdatePlaybackOffset
GetImageContainer/InvalidateWithFlags/Invalidate
IsShutdown
CanPlayThrough
GetCDMProxy

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

What remains after bug 1203877 is fixed:
SetMediaSeekable/IsTransportSeekable/IsMediaSeekable
GetImageContainer/InvalidateWithFlags/Invalidate
IsShutdown
CanPlayThrough
GetCDMProxy

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

mVideoFrameContainer assigned in MediaDecoder::Init and will not change again so it is thread safe. We don't have to fix GetImageContainer/InvalidateWithFlags/Invalidate.

What remians:
SetMediaSeekable/IsTransportSeekable/IsMediaSeekable
IsShutdown
CanPlayThrough
GetCDMProxy

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

What remians: GetCDMProxy
The last one!

Comment 5

[Bobby Holley (:bholley)]

(In reply to JW Wang [:jwwang] from comment #4)
> What remians: GetCDMProxy
> The last one!

\o/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Resolved as all dependents are fixed.