Closed
Bug 1209039
Opened 9 years ago
Closed 6 years ago
The build system doesn't like pthread_setname_np
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: nical, Unassigned)
References
Details
Attachments
(1 file)
1.60 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Moz2D needs to create some threads so I copy-pased this from the js engine https://dxr.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680/js/src/vm/PosixNSPR.cpp#148 which lets me have thread names, but task cluster build turns orange: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a8d863565417
Moz2D cannot use nspr xpcom or any gecko dependency except mfbt. How can I get thread names to work (like js).
Reporter | ||
Comment 3•9 years ago
|
||
These checks appear to be rather new since the same code worked 4 days ago, but grep doesn't find the error message in mozilla-inbound.
Summary: TaskCluster builds don't like pthread_setname_np → The build system doesn't like pthread_setname_np
Reporter | ||
Comment 4•9 years ago
|
||
The patch that removes the call to pthread_setname_np to get inbound green. It'd be great to have thread names back in Moz2D, though.
Attachment #8666684 -
Flags: review+
Reporter | ||
Comment 6•9 years ago
|
||
Mike, is there something I can do in moz2d to be able to use pthread_setname_np like the js engine does (without depending on xpcom or js)?
Flags: needinfo?(mh+mozilla)
Comment 7•9 years ago
|
||
That code from the js engine is not used in Firefox, that's why it's not causing problems. I think the reasonable thing for you to do is to use NSPR and have stubs when not building within Firefox, which is what the js engine has.
Flags: needinfo?(mh+mozilla)
Comment 8•9 years ago
|
||
(or use thread pools from xpcom, btw)
Updated•6 years ago
|
Keywords: leave-open
Whiteboard: [leave-open]
Reporter | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(nical.bugzilla)
Resolution: --- → WONTFIX
Updated•6 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•