[meta] Multi-threaded job scheduler

NEW
Assigned to

Status

()

P3
normal
3 years ago
2 months ago

People

(Reporter: nical, Assigned: nical)

Tracking

(Depends on: 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Tracking bug for the job scheduler.
(Assignee)

Updated

3 years ago
Assignee: nobody → nical.bugzilla
Depends on: 1239288, 1210669, 1239290
(Assignee)

Updated

3 years ago
Blocks: 1083101
(Assignee)

Updated

3 years ago
Depends on: 1209039
(Assignee)

Updated

3 years ago
Depends on: 1263212
(Assignee)

Updated

3 years ago
Depends on: 1264301
(Assignee)

Updated

3 years ago
Depends on: 1264305
(Assignee)

Updated

3 years ago
Depends on: 1266991
Keywords: meta
(Assignee)

Comment 1

a year ago
Created attachment 8892910 [details] [diff] [review]
Remove the job scheduler

We dropped the idea of multi-threaded tile rendering so we don't have a use case for this right now, there are bitrotted patches pending on reviews for a year, and more importantly several seconds spent running the scheduler tests in each push, which is a waste of infra since we don't have plans to use this in the foreseeable future.

If we look into something like this again in the future, rust would be a much better place for building this type of system.
Attachment #8892910 - Flags: review?(jmuizelaar)
Attachment #8892910 - Flags: review?(jmuizelaar) → review+

Comment 2

a year ago
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009af86a3026
Remove the gfx job scheduler. r=jrmuizel
Backed out for build bustage at StyleSheetInlines.h(77):

https://hg.mozilla.org/integration/mozilla-inbound/rev/494b52e3b462caafa3cae7832b58fb0dbd589925

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=009af86a30269949fa6777db130722b975c9605b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=120655241&repo=mozilla-inbound

09:10:04     INFO -  Unified_cpp_gfx_tests_gtest0.cpp
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInlines.h(77): error C2287: 'mozilla::StyleSheet': inheritance representation: 'single_inheritance' is less general than the required 'multiple_inheritance'
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInfo.h(17): note: see declaration of 'mozilla::StyleSheet'
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInlines.h(77): fatal error C1903: unable to recover from previous error(s); stopping compilation
09:10:04     INFO -  z:/build/build/src/config/rules.mk:1050: recipe for target 'Unified_cpp_gfx_tests_gtest0.obj' failed
09:10:04     INFO -  mozmake.EXE[5]: *** [Unified_cpp_gfx_tests_gtest0.obj] Error 2
Flags: needinfo?(nical.bugzilla)
(Assignee)

Updated

a year ago
Flags: needinfo?(nical.bugzilla)
We should reland this.
Flags: needinfo?(nical.bugzilla)
(Assignee)

Comment 5

a year ago
Pushed this to try again today and the windows builds are still failing on some mysterious and unrelated code, due to unified build hazards I presume. https://treeherder.mozilla.org/#/jobs?repo=try&author=nsilva@mozilla.com&selectedJob=130637149

This is pretty far down my list, so I don't think I'll investigate it in the short term. We could comment out the test as a short term thing if we want to save some infra.
Flags: needinfo?(nical.bugzilla)
You need to log in before you can comment on or make changes to this bug.