1209052 - URL autocomplete interferes with Swiftkey (and possibly other custom keyboards)

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

As per 

https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/14A173EA-3873-4C7D-AA29-77EE24A6127E%40sheppyware.net

"If you pause for even a moment while typing, autocorrect suggestions are immediately accepted, even if you keep typing. This results in mangled urls. In this screenshots it should replace the highlighted text when I continue typing but instead it adds the new character to the end."

Comment 1

[Aaron Train [:aaronmt]]

Catalin, are you able to reproduce this on your iPad?

Comment 3

[Eric Shepherd [:sheppy]]

I have more notes on the bug I duped to this one. Copying here for easier reference:

While typing a URL, if I pause for a moment while a set of suggestions is displayed, the suggestion gets inserted into the URL bar, resulting in this screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=8668075

Even though the inserted text is displayed as highlighted, suggesting that continuing to type will replace that and let you continue typing the URL you're trying to enter, instead that text is kept as part of the URL, resulting in you getting something you don't expect if you're not paying attention.

Note: The fact that the keyboard is missing in this screenshot is apparently a capture glitch due to the 3rd party onscreen keyboard I'm using.

Comment 4

[Catalin Suciu [:csuciu]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Catalin, are you able to reproduce this on your iPad?

I can't reproduce on current TestFlight build (1103) using Swiftkey and Fleksy keyboards.

In my case, the behaviour is:
If I don't have a history of what I'm typing, no suggestions are inserted into the URL
If I have a history, then the autocomplete suggestion is inserted into the URL bar, but I don't see any editing issues here.
 
Tested on:
iPad Air (iOS 9)
iPhone 6 Plus (iOS 9)

@sheppy: What keyboard did you use?

Comment 5

[Eric Shepherd [:sheppy]]

I'm using Swiftkey, for what it's worth.

Comment 6

[Dan Mellem]

I just downloaded it from the store (1.1 1113) and am having trouble when using SwiftKey. If I try to delete the URL a letter at a time by holding in the delete key, the suggestion keeps getting added back in.

IOS 9.1; SwiftKey 1.4.2

Comment 7

[Catalin Suciu [:csuciu]]

(In reply to Dan Mellem from comment #6)
> I just downloaded it from the store (1.1 1113) and am having trouble when
> using SwiftKey. If I try to delete the URL a letter at a time by holding in
> the delete key, the suggestion keeps getting added back in.
> 
> IOS 9.1; SwiftKey 1.4.2

I see the same behaviour on Safari when using SwiftKey

Comment 8

[Dan Mellem]

I haven't experienced this with Safari. The only similar thing I've seen with Safari is autocomplete expanding the URL but deleting essentially extends the highlight. With SwiftKey, there's no highlight, so the deleting ends up taking you to the end of the suggestion again.

Comment 9

[Eric Shepherd [:sheppy]]

This happens with every third-party keyboard I've tried, and still happens even on the latest 1.4 TestFlight builds. It makes the URL bar a pain to use increasingly often as the number of bookmarks and/or history entries go up.

Comment 10

[Catalin Suciu [:csuciu]]

Eric, would you mind checking if this issue still exists in the latest release?

Thanks.

Comment 11

[Eric Shepherd [:sheppy]]

Yes, this still happens to me.

Comment 12

[Farhan Patel [:farhan]]

This should be fixed by 
https://github.com/mozilla-mobile/firefox-ios/commit/b7d2697641fda38ee9851650f01fb62ad207adb5

Comment 13

[Simon Basca [:SimonB]]

Eric, can you please check if this issue is still reproducible in the latest releases? Thanks.