1209226 - Provide a terms of agreement page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Andy McKay]

To access an API key, developers will first need to agree to the terms and conditions, if they haven't then they will need to do so. 

The terms and conditions are shown on add-on submission, but we don't want to show them in the API as per bug 1205904.

For an example how this can work see the marketplace at https://marketplace.allizom.org/developers/api, although I note it doesn't stop you getting an API key.... hmm that might be a bug.

Comment 1

[Mathieu Agopian [:magopian]]

How do we deal with updates to the terms and conditions?

Comment 2

[Andy McKay]

(In reply to Mathieu Agopian [:magopian] from comment #1)
> How do we deal with updates to the terms and conditions?

The terms and conditions state that we will notify people of substantive changes in blog posts, but they can change any time. Please see bug 1205904 comment 0 for more. 

If a significant change happens, we can compare the date of the change to when the developer accepted them (its stored on the user model) and show them a message. I would consider that out of scope for this set of bugs though.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/86f574a19a81d847eefb4e1753e525503890111f
Added separate ToS page (bug 1209226)

https://github.com/mozilla/olympia/commit/e2a337a30e84bc81a624e2546293a3589b8eadeb
Merge pull request #796 from Nolski/signing-api-agreement

Added separate ToS page (bug 1209226)

Comment 4

[Victor Carciu]

Verified as fixed : http://screencast.com/t/pygwCl4x

Comment 5

[Mathieu Agopian [:magopian]]

PR was: https://github.com/mozilla/olympia/pull/796/