1209370 - Update l20n.js to 3.1.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1209370-l20n-3.1.0 > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8667072 [details] [review]
[gaia] stasm:1209370-l20n-3.1.0 > mozilla-b2g:master

Land at will. (seems like you may need to try on another base revision, since this one has some tv_apps oranges).

If would be awesome if you could test raptor for FM before landing, just in case.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Flame-kk, RUNS=31, default language

master:
| Metric                | Mean     | Median | Min    | Max    | StdDev  | p95      |
| --------------------- | -------- | ------ | ------ | ------ | ------- | -------- |
| navigationLoaded      | 3712.516 | 3723   | 3096   | 3841   | 125.725 | 3832.850 |
| navigationInteractive | 3847.323 | 3858   | 3230   | 3974   | 125.673 | 3967.750 |
| visuallyLoaded        | 4052.194 | 4061   | 3461   | 4197   | 122.277 | 4172     |
| contentInteractive    | 4052.323 | 4061   | 3461   | 4197   | 122.303 | 4172     |
| fullyLoaded           | 4052.710 | 4061   | 3462   | 4197   | 122.210 | 4173     |
| uss                   | 21.036   | 21.098 | 20.562 | 21.203 | 0.174   | 21.162   |
| rss                   | 43.423   | 43.484 | 42.949 | 43.590 | 0.174   | 43.549   |
| pss                   | 26.051   | 26.112 | 25.577 | 26.218 | 0.173   | 26.177   |

3.1.0:
| Metric                | Mean     | Median | Min    | Max    | StdDev  | p95      |
| --------------------- | -------- | ------ | ------ | ------ | ------- | -------- |
| navigationLoaded      | 3620.355 | 3622   | 2951   | 3776   | 136.307 | 3757.700 |
| navigationInteractive | 3757.032 | 3750   | 3129   | 3909   | 130.079 | 3901.100 |
| visuallyLoaded        | 3982     | 3957   | 3368   | 4761   | 188.657 | 4106.950 |
| contentInteractive    | 3982.226 | 3957   | 3368   | 4761   | 188.618 | 4106.950 |
| fullyLoaded           | 3982.742 | 3958   | 3369   | 4761   | 188.527 | 4107     |
| pss                   | 25.983   | 26.105 | 25.574 | 26.215 | 0.225   | 26.141   |
| uss                   | 20.963   | 21.086 | 20.555 | 21.195 | 0.225   | 21.121   |
| rss                   | 43.350   | 43.473 | 42.941 | 43.582 | 0.225   | 43.508   |

Comment 4

[Staś Małolepszy :stas]

Flame-kk, RUNS=30, non-default language

master:
| Metric                | Mean     | Median   | Min    | Max    | StdDev  | p95    |
| --------------------- | -------- | -------- | ------ | ------ | ------- | ------ |
| navigationLoaded      | 3406.600 | 3409     | 3072   | 3599   | 103.446 | 3582   |
| navigationInteractive | 3619.333 | 3639.500 | 3198   | 3745   | 100.326 | 3718   |
| visuallyLoaded        | 3619.533 | 3639.500 | 3198   | 3745   | 100.401 | 3719   |
| contentInteractive    | 3620.067 | 3640     | 3199   | 3746   | 100.258 | 3719   |
| fullyLoaded           | 3915.700 | 3817.500 | 3408   | 6395   | 504.618 | 4808   |
| uss                   | 16.142   | 16.127   | 16.078 | 16.625 | 0.095   | 16.195 |
| pss                   | 19.999   | 19.983   | 19.925 | 20.473 | 0.097   | 20.063 |
| rss                   | 37.744   | 37.715   | 37.652 | 38.203 | 0.102   | 37.824 |

3.1.0:
| Metric                | Mean     | Median   | Min    | Max    | StdDev  | p95    |
| --------------------- | -------- | -------- | ------ | ------ | ------- | ------ |
| navigationLoaded      | 3409.733 | 3407.500 | 2762   | 3642   | 154.391 | 3617   |
| navigationInteractive | 3619.833 | 3648     | 2887   | 3789   | 156.774 | 3787   |
| visuallyLoaded        | 3620.333 | 3648     | 2888   | 3792   | 156.840 | 3789   |
| contentInteractive    | 3620.833 | 3648.500 | 2888   | 3792   | 156.908 | 3790   |
| fullyLoaded           | 3792.367 | 3803.500 | 3146   | 3985   | 142.316 | 3963   |
| uss                   | 16.152   | 16.131   | 16.074 | 16.691 | 0.105   | 16.211 |
| pss                   | 20.003   | 19.980   | 19.916 | 20.533 | 0.106   | 20.074 |
| rss                   | 37.753   | 37.717   | 37.652 | 38.270 | 0.110   | 37.844 |

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Z3, Runs=31, default

master:
| Metric                | Mean    | Median | Min    | Max    | StdDev  | p95      |
| --------------------- | ------- | ------ | ------ | ------ | ------- | -------- |
| navigationLoaded      | 463.677 | 462    | 410    | 524    | 28.606  | 517.950  |
| navigationInteractive | 536.161 | 535    | 489    | 598    | 27.764  | 591.600  |
| visuallyLoaded        | 730.065 | 634    | 578    | 3022   | 430.307 | 1145.700 |
| contentInteractive    | 730.258 | 634    | 579    | 3023   | 430.447 | 1145.750 |
| fullyLoaded           | 730.452 | 634    | 579    | 3023   | 430.397 | 1145.750 |
| pss                   | 20.909  | 20.914 | 20.603 | 20.990 | 0.064   | 20.980   |
| uss                   | 16.521  | 16.520 | 16.453 | 16.590 | 0.033   | 16.585   |
| rss                   | 35.996  | 35.992 | 35.918 | 36.086 | 0.037   | 36.069   |

3.1.0:
| Metric                | Mean    | Median | Min    | Max    | StdDev | p95     |
| --------------------- | ------- | ------ | ------ | ------ | ------ | ------- |
| navigationLoaded      | 461.871 | 465    | 390    | 529    | 29.696 | 518.500 |
| navigationInteractive | 533.419 | 534    | 464    | 608    | 29.947 | 592.250 |
| visuallyLoaded        | 626.032 | 627    | 551    | 736    | 34.754 | 687.350 |
| contentInteractive    | 626.290 | 627    | 552    | 737    | 34.726 | 687.350 |
| fullyLoaded           | 626.419 | 628    | 552    | 737    | 34.733 | 687.350 |
| uss                   | 16.508  | 16.504 | 16.461 | 16.617 | 0.032  | 16.574  |
| pss                   | 20.911  | 20.910 | 20.862 | 21.017 | 0.031  | 20.977  |
| rss                   | 35.990  | 35.988 | 35.941 | 36.090 | 0.029  | 36.058  |

major stdev diff, nice fullyLoad win.

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 8667072 [details] [review]
[gaia] stasm:1209370-l20n-3.1.0 > mozilla-b2g:master

This new version of l20n requires minor changes in Music and in TV Dashboard.

:justindarc, I tried to simplify the Music app code in this PR.  Your use-case was one of the biggest motivations for the l20n API changes in this iteration.  We hope they make l20n easier to work with.  In particular, we introduced the formatValues method (bug 1204086), made all document.l10n methods safe to call at any time (bug 1207120) and replaced DOMLocalized with DOMRetranslated which fires on language change but not during startup (bug 1209363).

:rexboy, I also had to make a tiny change in tv_apps/dashboard and removed an empty data-l10n-id which was causing build errors.  It looks like you assign the l10n-id in js/digital_clock.js anyways so this should be safe.

Can you both take a look at these changes, please?

Comment 7

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8667072 [details] [review]
[gaia] stasm:1209370-l20n-3.1.0 > mozilla-b2g:master

Thanks for the patch! LGTM with comments addressed (please rename `this.onDOMLocalized` in the custom elements to `this.onDOMRetranslated` for consistency.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8667072 [details] [review]
[gaia] stasm:1209370-l20n-3.1.0 > mozilla-b2g:master

Looks good to me. Thanks!

Comment 9

[Staś Małolepszy :stas]

Thanks for the reviews!

https://github.com/mozilla-b2g/gaia/commit/adf1cb779df9ab5a4bd645fec164475b3c41763f

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Landed a small update to l20n.js to use gaia build, not the web build so that the proxy works - https://github.com/mozilla-b2g/gaia/commit/957ef299ba3aead26dd624757ddd3c06045ed110