Closed Bug 1209388 Opened 8 years ago Closed 8 years ago

Remove AppleMP3Reader

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Version:
43 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

[mp3] Remove AppleMP3Reader.
28.26 KB, patch
jya
: review+
Details | Diff | Splinter Review 
Instead we should be using the new MP3Demuxer / MediaFormatReader
Depends on: 1209410
Following bug 1209410, it was no longer used.
Attachment #8667724 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Comment on attachment 8667724 [details] [diff] [review]
[mp3] Remove AppleMP3Reader.

Carrying r+ from bug 1209410.

git bz got confused with the two bug numbers in the commit message and uploaded it in the wrong spot
Attachment #8667724 - Flags: review?(ajones) → review+
Time to land now?
Flags: needinfo?(jyavenard)
Priority: -- → P2
See Also: → 1222725
Flags: needinfo?(jyavenard)
And ignore my commit message saying "on 10.6", while pulsebot was midairing me I was discovering that it did fail on 10.10, we just only manage to run tests on 10.10 once every three or four hours.
https://hg.mozilla.org/mozilla-central/rev/1af31ad7eefc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
it is resolved, it's only the patch to remove the pref that got backed out (i incorrectly also removed the mp4 pref which is what caused the bustage)
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.