1209388 - Remove AppleMP3Reader

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

Instead we should be using the new MP3Demuxer / MediaFormatReader

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [mp3] Remove AppleMP3Reader.

Following bug 1209410, it was no longer used.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8667724 [details] [diff] [review]
[mp3] Remove AppleMP3Reader.

Carrying r+ from bug 1209410.

git bz got confused with the two bug numbers in the commit message and uploaded it in the wrong spot

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecbe6589d36e

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9541a3be9d9f

Comment 6

[Ralph Giles (:rillian)]

Time to land now?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1af31ad7eefc

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d431c8667a3

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ede421c34977

Comment 10

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ede421c34977 - https://treeherder.mozilla.org/logviewer.html#?job_id=17498962&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=17498970&repo=mozilla-inbound are of the opinion that you made us at least think we can't play audio, if not made us unable to play audio.

Comment 11

[Phil Ringnalda (:philor)]

And ignore my commit message saying "on 10.6", while pulsebot was midairing me I was discovering that it did fail on 10.10, we just only manage to run tests on 10.10 once every three or four hours.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1af31ad7eefc

Comment 13

[Jean-Yves Avenard [:jya]]

it is resolved, it's only the patch to remove the pref that got backed out (i incorrectly also removed the mp4 pref which is what caused the bustage)