1209536 - [Dialer] Callscreen can't be dismissed in some situations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Calling somebody who doesn't answer.
2. Press the "hang up" button.
3. Very quickly, before the callscreen disappear, you have the time to press home, show the utility tray, and press the "callscreen" notification line.

=> what happened to me is that the callscreen panel would then never disappear: I could see it in the utility tray, I could display it, I could press home to dismiss it but then I would see the blue glowing indicator at the top of the screen and the notification would be back.

I reproduce really easily on Sony, not so easily on my Flame (but my utility tray is slow there because I don't have bug 1178162 yet :) ).

Comment 1

[Mahendra Potharaju [:mahe]]

[Tracking Requested - why for this release]:

Removing nomination for 2.5. Not usual STR.

Comment 2

[Gabriele Svelto [:gsvelto]]

Looking at your STR this smells a lot like an issue in the system app's window management or somewhere else rather than in the callscreen. I wonder if this is related to bug 1078448.

Comment 3

[Julien Wajsberg [:julienw]]

[Blocking Requested - why for this release]:
Renominating.
Reason: I got the issue without especially looking for it. And then we're pretty much stuck and need to reboot. (Maybe it's possible to recover by having or receiving a call too, I haven't tried).

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Race condition that puts the dialer in bad state that is hard to recover from.

Comment 5

[Gabriele Svelto [:gsvelto]]

BTW I doubt this is a dialer bug, it's far more likely to be related to window management in the system app. The dialer will always eventually close itself after the last call has been hung up, see the code here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/js/calls_handler.js#L346

Comment 6

[Gabriele Svelto [:gsvelto]]

Etienne, could you have a look and check what happens in the window manager / callscren agent when we hit this bug? I'd do it myself but I'm still grappling other blockers for now.

Comment 7

[Etienne Segonzac (:etienne)]

I can only test on a flame, but I can't reproduce the issue on mater.
That said, I was able to follow the STR and make the re-opening of the callscreen race the window.close() and it still got removed properly.

It's possible that bug 1202909 fixed it so it's worth re-testing on master is somebody can.

Comment 8

[Gabriele Svelto [:gsvelto]]

Thanks for testing:

(In reply to Etienne Segonzac (:etienne) from comment #7)
> It's possible that bug 1202909 fixed it so it's worth re-testing on master
> is somebody can.

Good point, I hadn't thought about that.

Comment 9

[Julien Wajsberg [:julienw]]

mmm I'm quite sure I had a build older than bug 1202909 and I reproduced. I'll try again :)

Comment 10

[Johan Lorenzo [:jlorenzo]]

I repro'd on the laster master[1]. See this video for the steps and the effects of it: https://goo.gl/g30o9P . One tricky part of the STR is: you have to bring back the call screen right when the end call banner is displayed. Otherwise the correct call screen will re-appear, and will correctly be dismissed.

[1] Build ID               20151006110347
Gaia Revision          60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gaia Date              2015-10-06 04:50:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/89732fcdb0baca70e8b7a25a2725117113f0db80
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151006.102229
Firmware Date          Tue Oct  6 10:22:38 UTC 2015
Bootloader             s1

Comment 11

[Julien Wajsberg [:julienw]]

Just reproduced on the first try on a Sony with a build from Oct 06th.

Comment 12

[Etienne Segonzac (:etienne)]

I'm fairly confident this is a WindowManager issue, Johan if you can lend me a z3c-sized test sim card sometime this week I'll take a look.

Comment 13

[Etienne Segonzac (:etienne)]

Got a phone with a sim, taking :)

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1209536-lingering-attention-screen > mozilla-b2g:master

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8674222 [details] [review]
[gaia] etiennesegonzac:bug-1209536-lingering-attention-screen > mozilla-b2g:master

Flagging Julien for feedback since he has the magic touch when it comes to reproducing this bug :)

But the review is all yours Alberto!

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 8674222 [details] [review]
[gaia] etiennesegonzac:bug-1209536-lingering-attention-screen > mozilla-b2g:master

I don't seem to reproduce it :)

Great job !

Comment 17

[Julien Wajsberg [:julienw]]

I think the behavior could be improved in the future though:

When the user presses "home" and the call already ended, maybe the callscreen could be closed instead of minimized. We can assume the intent of the user pressing "home" at that moment is to close the callscreen completely anyway.

Comment 18

[Alberto Pastor [:albertopq]]

Comment on attachment 8674222 [details] [review]
[gaia] etiennesegonzac:bug-1209536-lingering-attention-screen > mozilla-b2g:master

Nice! Thanks

Comment 19

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/cf5f2a5bf41d2db088f7f5ade5dfa4c01f91b6f2