1209615 - make RootAccessible::RelationByType() work with e10s

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

RootAccessible::RelationByType() returns the currently active tab's top level document accessible as the target of the embeds relation.  However with e10s that doesn't work because the top level tap document is remote and so there isn't a window / document for it.  We need to add a way to get the active TabParent, and then get the top level DocAccessibleParent for that, and return that as the target of the embeds relation.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: add TabParent::GetTopLevelDocAccessible()

We're going to need to use this in multiple places so it makes to add a function for it now

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: use TabParent::GetTopLevelDocAccessible() in OuterDocAccessible::RemoteChildDoc()

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: add RootAccessible::GetPrimaryRemoteTopLevelContentDoc()

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: make remote primary docs RELATION_EMBEDS targets for atk

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8670434 [details] [diff] [review]
add TabParent::GetTopLevelDocAccessible()

Wrong patch? I was not expecting to see CameraManager.cpp stuff.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8670437 [details] [diff] [review]
add RootAccessible::GetPrimaryRemoteTopLevelContentDoc()

Review of attachment 8670437 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/RootAccessible.cpp
@@ +724,5 @@
> +  mDocumentNode->GetDocShell()->GetTreeOwner(getter_AddRefs(owner));
> +  NS_ENSURE_TRUE(owner, nullptr);
> +
> +  nsCOMPtr<nsITabParent> tabParent;
> +    owner->GetPrimaryTabParent(getter_AddRefs(tabParent));

nit: too much indent.

::: accessible/generic/RootAccessible.h
@@ +44,5 @@
>  
> +  /**
> +   * Return the primary remote top level document if any.
> +   */
> +  ProxyAccessible* GetPrimaryRemoteTopLevelContentDoc() const;

Maybe this would be better as 'GetPrimaryRemoteTabTopLevelDocAccessible' but I'm not sure.

Comment 7

[Trevor Saunders (:tbsaunde)]

Attachment: add TabParent::GetTopLevelDocAccessible()

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8670438 [details] [diff] [review]
make remote primary docs RELATION_EMBEDS targets for atk

Review of attachment 8670438 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/AccessibleWrap.cpp
@@ +988,5 @@
> +        aAcc->AsRoot()->GetPrimaryRemoteTopLevelContentDoc()) {
> +      targets.AppendElement(GetWrapperFor(proxyDoc));
> +    }
> +  }
> +

I guess we'll have an extraneous (useless?) relation for this embeds already created in RelationByType?

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8670471 [details] [diff] [review]
add TabParent::GetTopLevelDocAccessible()

>+TabParent::GetTopLevelDocAccessible() const
>+{
>+  // XXX Consider managing non top level remote documents with there parent
>+  // document.
I don't understand what the comment is about and s/there/their/ I think.
But perhaps remove the whole comment.
Oh, is "document" in the comment about DocAccessibleParent. I have DOM view of the world, so 'document' means
DOM Document to me ;)

Comment 10

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/30c52fc05c80
https://hg.mozilla.org/mozilla-central/rev/61a73fb35482
https://hg.mozilla.org/mozilla-central/rev/605191307c3a
https://hg.mozilla.org/mozilla-central/rev/81ed1750e33a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/30c52fc05c80
https://hg.mozilla.org/mozilla-central/rev/61a73fb35482
https://hg.mozilla.org/mozilla-central/rev/605191307c3a
https://hg.mozilla.org/mozilla-central/rev/81ed1750e33a