1209755 - [EME] Enable Adobe EME in official 64bit builds in Nightly, Aurora, and Beta

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Adobe are just about ready to give us a 64bit production EME CDM. So we should enable Adobe EME in official 64bit builds.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Enable Adobe EME in 64bit official builds.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4823e6a7023c

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Uplift needed.

Comment 4

[Chris Peterson [:cpeterson]]

Once we have a 64-bit Nightly build with working EME, we can ask coop to schedule 64-bit EME-free repacks in bug 1185105.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4823e6a7023c

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e657c22d317

Rebased beta patch:
https://hg.mozilla.org/try/raw-rev/4ad64b25ac5b


Aurora try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d96adc84f158
(4823e6a7023c applies cleanly to Aurora)

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8667634 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: EME/Netflix won't work in Win64 Firefox
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests.
[Risks and why]: Low; we already run this in Win32 Firefox.
[String/UUID change made/needed]: None.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8667634 [details] [diff] [review]
Patch

Yeh! Increase the win 32/64 parity, taking it. should be in 42b3.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9da8a4522b7a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9da8a4522b7a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/989edb32c8e5

Comment 12

[Ada [:adalucinet]]

Attachment: ErrorMessageNetflix.png

Adobe EME is properly downloaded on 42.0b5 (Build ID: 20151008162217), latest 43.0a2 Aurora and 44.0a1 Nightly, under Windows 7 and Windows 10, 64-bit.

Two issues encountered after performing some additional exploratory testing:
1. When restarting Firefox while a video plays via Netflix, the attached error message is displayed (*note* that Netflix was running in one tab only); works after reloading the page though; I guess this could be due bug 925570?  
2. on Windows 10, I am unable to play any Netflix video on 43.0a2, 42 beta 5 and 6 - the loading state is displayed constantly, but it works with 44.0a1. Is this issue under your radar? Or do you have any idea what this could've fix it on latest Nightly? 

Thanks in advance, Chris!

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #12)
> Created attachment 8672963 [details]
> ErrorMessageNetflix.png
> 
> Adobe EME is properly downloaded on 42.0b5 (Build ID: 20151008162217),
> latest 43.0a2 Aurora and 44.0a1 Nightly, under Windows 7 and Windows 10,
> 64-bit.
> 
> Two issues encountered after performing some additional exploratory testing:
> 1. When restarting Firefox while a video plays via Netflix, the attached
> error message is displayed (*note* that Netflix was running in one tab
> only); works after reloading the page though; I guess this could be due bug
> 925570?  

Is that Nightly, and do you have e10s enabled? He had an issue with e10s enabled (bug 1186258), and also bug 1175317 at low volume.


> 2. on Windows 10, I am unable to play any Netflix video on 43.0a2, 42 beta 5
> and 6 - the loading state is displayed constantly, but it works with 44.0a1.
> Is this issue under your radar? Or do you have any idea what this could've
> fix it on latest Nightly? 
> 
> Thanks in advance, Chris!

Netflix have only enabled playback by default on Firefox Nightly 44. It's not enabled by default on Beta and Aurora channels. You can test on Beta/Aurora by overriding the navigator.useragent string using general.useragent.override pref.

Note: you don't need to test via beta.netflix.com anymore; you should be able to test on http://netflix.com now.

Comment 14

[Ada [:adalucinet]]

(In reply to Chris Pearce (:cpearce) from comment #13)
> (In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #12)
> > Created attachment 8672963 [details]
> > ErrorMessageNetflix.png
> > 
> > Adobe EME is properly downloaded on 42.0b5 (Build ID: 20151008162217),
> > latest 43.0a2 Aurora and 44.0a1 Nightly, under Windows 7 and Windows 10,
> > 64-bit.
> > 
> > Two issues encountered after performing some additional exploratory testing:
> > 1. When restarting Firefox while a video plays via Netflix, the attached
> > error message is displayed (*note* that Netflix was running in one tab
> > only); works after reloading the page though; I guess this could be due bug
> > 925570?  
> 
> Is that Nightly, and do you have e10s enabled? He had an issue with e10s
> enabled (bug 1186258), and also bug 1175317 at low volume.

Indeed only with e10s enabled, both Nightly and Aurora. This is applicable for both x32 and x64 builds. Unfortunately, I cannot access any of the given bugs.

> > 2. on Windows 10, I am unable to play any Netflix video on 43.0a2, 42 beta 5
> > and 6 - the loading state is displayed constantly, but it works with 44.0a1.
> > Is this issue under your radar? Or do you have any idea what this could've
> > fix it on latest Nightly? 
> > 
> > Thanks in advance, Chris!
> 
> Netflix have only enabled playback by default on Firefox Nightly 44. It's
> not enabled by default on Beta and Aurora channels. You can test on
> Beta/Aurora by overriding the navigator.useragent string using
> general.useragent.override pref.

Apparently, now it works - I guess it may have been a connection problem. Sorry for the noise. Also, it was Windows 10 only issue, it worked under Windows 7 64-bit with x64 Firefox builds. 

> Note: you don't need to test via beta.netflix.com anymore; you should be
> able to test on http://netflix.com now.

Thanks for sharing!

Marking accordingly since the remaining issue is not 64bit builds related.